samba.git/source4/lib/socket/socket_ip.c, branch master

lib/util: remove extra safe_string.h file

2020-08-28T02:18:40+00:00

lib/util/safe_string.h is similar to source3/include/safe_string.h, but
the former has fewer checks. It is missing bcopy, strcasecmp, and
strncasecmp.

Add the missing elements to lib/util/safe_string.h remove the other
safe_string.h which is in the source3-specific path. To accomodate
existing uses of str(n?)casecmp, add #undef lines to source files where
they are used.

Signed-off-by: Matthew DeVore 
Reviewed-by: David Mulder 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Aug 28 02:18:40 UTC 2020 on sn-devel-184

lib: Remove unused SOCKET_FLAG_BLOCK

2020-03-25T09:04:28+00:00

Nobody in the code set this flag, so remove it

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

s4 lib socket: Ensure address string owned by parent struct

2019-05-08T20:03:42+00:00

The local address string was not owned by it's parent structure, which
caused a use after free error in
continue_ip_open_socket source4/librpc/rpc/dcerpc_sock.c:267

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13929

Signed-off-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed May  8 20:03:42 UTC 2019 on sn-devel-184

s4:lib: Use #ifdef instead of #if for config.h definitions

2018-11-28T22:19:24+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Gary Lockyer

libsocket: Avoid an unnecessary else branch

2018-02-13T20:07:17+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Tue Feb 13 21:07:17 CET 2018 on sn-devel-144

source4/lib/socket/socket_ip.c set socket close on exec

2017-12-18T07:49:57+00:00

Set SOCKET_CLOEXEC on the sockets returned by accept.  This ensures that
the socket is unavailable to any child process created by system().
Making it harder for malicious code to set up a command channel,
as seen in the exploit for CVE-2015-0240

Signed-off-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Mon Dec 18 08:49:57 CET 2017 on sn-devel-144

lib: Fix a pointless error check

2016-08-05T20:20:05+00:00

According to susv4, addr.s6_addr is a

uint8_t s6_addr[16]

which is always != 0

Signed-off-by: Volker Lendecke 
Reviewed-by: Martin Schwenke

s3: Fix the clustering build

2011-12-17T17:41:39+00:00

ctdb_private.h already defines set_close_on_exec.

Autobuild-User: Volker Lendecke 
Autobuild-Date: Sat Dec 17 18:41:39 CET 2011 on sn-devel-104

s4-socket: use set_close_on_exec()

2011-12-15T22:36:22+00:00

this prevents a fd leak to child processes

s4:lib/socket: don't pass -1 to close()

2011-10-31T15:02:42+00:00

metze