samba.git/source4/libcli/ldap/ldap_client.c, branch talloc-2.3.0 Unnamed repository; edit this file 'description' to name the repository. s4/libcli/ldab: clang: Fix 'Access results in a deref of a null pointer' 2019-07-16T22:52:24+00:00 Noel Power noel.power@suse.com 2019-07-10T15:13:38+00:00 8aed7e9aae13b3fc64a2af1fbdf835f12038ac9b Fixes: source4/libcli/ldap/ldap_client.c:1023:6: warning: Access to field 'type' results in a dereference of a null pointer <--[clang] if ((*msg)->type != type) { ^~~~~~~~~~~~ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz> 
Fixes:

source4/libcli/ldap/ldap_client.c:1023:6: warning: Access to field 'type' results in a dereference of a null pointer <--[clang]
        if ((*msg)->type != type) {
            ^~~~~~~~~~~~

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
libcli/ldap: Remove unsued ldap_transaction() 2019-05-22T05:59:14+00:00 Andrew Bartlett abartlet@samba.org 2019-05-21T03:42:39+00:00 5b957f816c8647c6423926ee47243ff0bb1e09e5 This is unsued since a87dea2a0894015cf4a3140995791f5468c40038 in 2007 when we moved to using LDB for LDAP in this area of the code. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz> 
This is unsued since a87dea2a0894015cf4a3140995791f5468c40038 in 2007
when we moved to using LDB for LDAP in this area of the code.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
libsocket: Add "mem_ctx" to socket_create() 2018-02-27T08:14:17+00:00 Volker Lendecke vl@samba.org 2018-02-15T15:43:59+00:00 d88f826c7b78d84fef87ab1301b266f11b4162fb Every caller did a talloc_steal() after socket_create(). Just pass in the correct memory context. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> 
Every caller did a talloc_steal() after socket_create(). Just pass in the
correct memory context.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
util/rfc1738_unescape(): return end pointer or NULL on error 2018-02-22T00:04:18+00:00 Douglas Bagnall douglas.bagnall@catalyst.net.nz 2018-02-16T21:46:44+00:00 a4c853a7deb080dd44e3c54eb45935ff0df91baf At present we don't detect errors, but when we do we'll return NULL. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
At present we don't detect errors, but when we do we'll return NULL.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
typo: mplementation => implementation 2016-05-06T03:03:16+00:00 Garming Sam garming@catalyst.net.nz 2016-04-20T05:10:41+00:00 38e08d71740b9f840c6750bef47ffb32889fdf3e Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> 
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
CVE-2016-2113: s4:libcli/ldap: verify the server certificate and hostname if configured 2016-04-12T17:25:25+00:00 Stefan Metzmacher metze@samba.org 2015-12-23T15:17:04+00:00 4b679c350a7fdaab114b6c7d05e6a6b12e903c3d BUG: https://bugzilla.samba.org/show_bug.cgi?id=11752 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11752

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
CVE-2016-2113: s4:lib/tls: implement infrastructure to do peer verification 2016-04-12T17:25:25+00:00 Stefan Metzmacher metze@samba.org 2015-12-23T15:17:04+00:00 64a9cd2a38d8a9503560524f5a6feea25651f11c BUG: https://bugzilla.samba.org/show_bug.cgi?id=11752 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11752

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
s4:libcli/ldap: send AbandonRequests for cancelled requests 2016-02-17T02:43:22+00:00 Stefan Metzmacher metze@samba.org 2016-02-01T10:00:14+00:00 cd77b0bba434139e13db5ec2096ca99b6b3f084d This happens on a local timeout of an talloc_free() of the request. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
This happens on a local timeout of an talloc_free() of the request.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
libcli: Fix a typo 2016-01-13T06:48:30+00:00 Volker Lendecke vl@samba.org 2015-12-17T14:42:33+00:00 9039f1f29eb971894d6c0276f99a39a140fe2013 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org> 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
lib/tls: Add new 'tls priority' option 2015-07-20T01:08:26+00:00 Andrew Bartlett abartlet@samba.org 2015-07-19T23:22:46+00:00 374d73617d71abf594cc92d335cd8bc60c10a1b7 This adds a new option to the smb.conf to allow administrators to disable TLS protocols in GnuTLS without changing the code. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11076 Pair-programmed-with: Garming Sam <garming@catalyst.net.nz> Signed-off-by: Garming Sam <garming@catalyst.net.nz> Signed-off-by: Andrew Bartlett <abartlet@samba.org> 
This adds a new option to the smb.conf to allow administrators to disable
TLS protocols in GnuTLS without changing the code.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11076
Pair-programmed-with: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>