samba.git/source4/libcli/ldap, branch talloc-2.4.0

s3-librpc: add ads.idl and convert ads_struct to talloc.

2022-12-16T20:38:32+00:00

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Jeremy Allison

CVE-2020-25720: s4-acl: Change behavior of Create Children check

2022-09-16T02:32:36+00:00

Up to now, the rights to modify an attribute were not checked during an LDAP
add operation. This means that even if a user has no right to modify
an attribute, they can still specify any value during object creation,
and the validated writes were not checked.
This patch changes this behavior. During an add operation,
a security descriptor is created that does not include the one provided by the
user, and is used to verify that the user has the right to modify the supplied attributes.
Exception is made for an object's mandatory attributes, and if the user has Write DACL right,
further checks are skipped.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14810

Pair-Programmed-With: Joseph Sutton 

Signed-off-by: Nadezhda Ivanova 
Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

dsdb: Return dsdb_password_change control name to DSDB_CONTROL_PASSWORD_CHANGE_OLD_PW_CHECKED_OID

2022-03-17T01:57:38+00:00

This makes it clearer that the purpose of this control is to indicate that the password
was already checked (by an out-of-band mechanism, eg kpasswd) and so can safely be changed
subject to ACLs etc.

This essentially reverts bbb9dc806e4399c65dee9b5dc2cde0bfaa9609bd

Signed-off-by: Andrew Bartlett 
Reviewed-by: Stefan Metzmacher

auth:creds: Add obtained arg to cli_credentials_set_gensec_features()

2021-04-28T03:43:34+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

ldap_client: Make ldap_parse_basic_url() IPv6-address aware

2020-07-02T12:01:06+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Alexander Bokovoy 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Thu Jul  2 12:01:06 UTC 2020 on sn-devel-184

ldap_client: Align integer types

2020-07-02T10:38:34+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Alexander Bokovoy

ldap_client: Make ldap_parse_basic_url take care of ldapi as well

2020-07-02T10:38:34+00:00

SUSV4's sscanf has the %m modifier, which allocates the right
amount. Remove those SMB_ASSERTS for string buffers.

Signed-off-by: Volker Lendecke 
Reviewed-by: Alexander Bokovoy

CVE-2020-10704: libcli ldap_message: Add search size limits to ldap_decode

2020-05-04T02:59:32+00:00

Add search request size limits to ldap_decode calls.

The ldap server uses the smb.conf variable
"ldap max search request size" which defaults to 250Kb.
For cldap the limit is hard coded as 4096.

Credit to OSS-Fuzz

REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334

Signed-off-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett

CVE-2020-10704: lib util asn1: Add ASN.1 max tree depth

2020-05-04T02:59:31+00:00

Add maximum parse tree depth to the call to asn1_init, which will be
used to limit the depth of the ASN.1 parse tree.

Credit to OSS-Fuzz

REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20454
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14334

Signed-off-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett

s4/libcli/ldab: clang: Fix 'Access results in a deref of a null pointer'

2019-07-16T22:52:24+00:00

Fixes:

source4/libcli/ldap/ldap_client.c:1023:6: warning: Access to field 'type' results in a dereference of a null pointer <--[clang]
        if ((*msg)->type != type) {
            ^~~~~~~~~~~~

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer