samba.git/source4/libcli/raw, branch talloc-2.3.2

smb: rename NTCREATEX_OPTIONS_PRIVATE_DENY_FCB to NTCREATEX_FLAG_DENY_FCB

2020-10-23T17:44:33+00:00

Just a shorter name, no change in behaviour.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

smb: rename NTCREATEX_OPTIONS_PRIVATE_DENY_DOS to NTCREATEX_FLAG_DENY_DOS

2020-10-23T17:44:33+00:00

Just a shorter name, no change in behaviour.

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison

libcli: Use GUID_to_ndr_buf() in smbcli_push_guid()

2020-10-02T21:30:34+00:00

Avoid two talloc/free

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

s4:libcli/smb2: allow smb2_connect*() to fake session and tcon

2020-07-08T15:54:38+00:00

For multichannel connection we want a way to have just a connection
with a negprot finished.

For now we just fake a tcon and session in order to avoid changes in the
caller. We can clean that up later if needed.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Günther Deschner

Implement alt name query for smb2

2020-04-28T18:09:39+00:00

Implements smb2_qpathinfo_alt_name() and
RAW_FILEINFO_SMB2_ALT_NAME_INFORMATION.

Signed-off-by: David Mulder 
Reviewed-by: Noel Power 
Reviewed-by: Jeremy Allison 
(cherry picked from commit 097df343ce21c8340aee7f42f233fe74b92b47e2)

s4/libcli/raw: clang: Fix 'Value stored to 'p' is never read'

2019-09-25T09:47:31+00:00

Fixes:

source4/libcli/raw/clisession.c:198:4: warning: Value stored to 'p' is never read <--[clang]
                        p += smbcli_req_pull_string(&req->in.bufinfo, mem_ctx, &parms->old.out.domain, p, -1, STR_TERMINATE);
                        ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source4/libcli/raw/clisession.c:212:5: warning: Value stored to 'p' is never read <--[clang]
                                p += smbcli_req_pull_string(&req->in.bufinfo, mem_ctx, &parms->nt1.out.domain, p, -1, STR_TERMINATE);
                                ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source4/libcli/raw/clisession.c:232:3: warning: Value stored to 'p' is never read <--[clang]
                p += smbcli_req_pull_string(&req->in.bufinfo, mem_ctx, &parms->spnego.out.workgroup, p, -1, STR_TERMINATE);
                ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Noel Power 
Reviewed-by: Andreas Schneider

s4/libcli/raw: clang: Fix 'Dereference of null pointer'

2019-09-25T09:47:31+00:00

Fixes:

source4/libcli/raw/rawfileinfo.c:597:2: warning: Dereference of null pointer <--[clang]
        SMBCLI_CHECK_WCT(req, 10);
        ^
source4/libcli/raw/rawfileinfo.c:639:2: warning: Dereference of null pointer <--[clang]
        SMBCLI_CHECK_WCT(req, 11);
        ^

Signed-off-by: Noel Power 
Reviewed-by: Andreas Schneider

s4/libcli/raw: clang: Fix 'Access to field results in a deref of a null ptr

2019-09-25T09:47:31+00:00

Fixes:

source4/libcli/raw/rawfileinfo.c:301:56: warning: Access to field 'transport' results in a dereference of a null pointer (loaded from variable 'session') <--[clang]
    parms->standard.out.create_time = raw_pull_dos_date2(session->transport,
                                                                         ^
source4/libcli/raw/rawfileinfo.c:314:55: warning: Access to field 'transport' results in a dereference of a null pointer (loaded from variable 'session') <--[clang]
    parms->ea_size.out.create_time = raw_pull_dos_date2(session->transport,

Signed-off-by: Noel Power 
Reviewed-by: Andreas Schneider

s4/libcli/raw: Fix 'Value stored to 'p' is never read'

2019-07-16T22:52:24+00:00

Fixes:

source4/libcli/raw/clitree.c:138:3: warning: Value stored to 'p' is never read <--[clang]
                p += smbcli_req_pull_string(&req->in.bufinfo, mem_ctx, &parms->tconx.out.fs_type,
                ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

s4/libcli/raw: clang: Fix 'initialization value is never read'

2019-07-16T22:52:24+00:00

Fixes:

source4/libcli/raw/rawnegotiate.c:157:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_INTERNAL_ERROR;
                 ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer