samba.git/source4/libcli/smb2, branch talloc-2.4.0

smbXcli: Pass negotiate contexts through smbXcli_negprot_send/recv

2022-08-26T19:54:03+00:00

We already don't allow setting max_credits in the sync wrapper, so
omit the contexts there as well.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Aug 26 19:54:03 UTC 2022 on sn-devel-184

s4/libcli/smb2: avoid using smb2_composite_setpathinfo() in smb2_util_setatr()

2022-08-23T11:52:29+00:00

smb2_composite_setpathinfo() uses SEC_FLAG_MAXIMUM_ALLOWED which can
have unwanted side effects like breaking oplocks if the effective access
includes [READ|WRITE]_DATA.

For changing the DOS attributes we only need SEC_FILE_WRITE_ATTRIBUTE. With this
change test_smb2_oplock_batch25() doesn't trigger an oplock break anymore.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15153

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

lib/util: Change function to mem_equal_const_time()

2022-06-09T22:49:29+00:00

Since memcmp_const_time() doesn't act as an exact replacement for
memcmp(), and its return value is only ever compared with zero, simplify
it and emphasize the intention of checking equality by returning a bool
instead.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

libcli/smb: pass smb3_capabilities to smbXcli_conn_create()

2021-03-17T00:49:32+00:00

Passing NULL means use none.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14512

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

libcli: Use GUID_to_ndr_buf() in smb2_create_send()

2020-10-02T21:30:34+00:00

Avoid talloc/free

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

s4:libcli: Require signing for SMB encryption

2020-08-19T16:22:43+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher

s4:libcli: Add smb2_connect_enc_start()

2020-08-19T16:22:43+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher

s3:libcli: Split out smb2_connect_tcon_start()

2020-08-19T16:22:43+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher

s4:libcli/smb2: add const to struct smbcli_options *options for smb2_connect()

2020-07-08T15:54:38+00:00

It will just be passed to smb2_connect_ext(), which already takes a
const pointer.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Günther Deschner

s4:libcli/smb2: allow smb2_connect*() to fake session and tcon

2020-07-08T15:54:38+00:00

For multichannel connection we want a way to have just a connection
with a negprot finished.

For now we just fake a tcon and session in order to avoid changes in the
caller. We can clean that up later if needed.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Günther Deschner