samba.git/source4/libcli/smb2, branch talloc-2.4.2 Unnamed repository; edit this file 'description' to name the repository. s4:libcli: Call correct function to get HMAC output length 2023-11-30T00:02:33+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2023-11-23T06:27:27+00:00 99ded98b3947e87b1ab99b7da0ecd6370b46fd1d Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
s4:libcli: Remove trailing whitespace 2023-11-30T00:02:33+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2023-11-23T06:26:53+00:00 769b65275261f1e97ab2698b3bf0c3f6d0174d85 Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
s4:libcli: Fix code spelling 2023-08-14T21:45:29+00:00 Andreas Schneider asn@samba.org 2023-08-03T12:34:51+00:00 950f0b47d94c572c0dc62cd256b8bf02f0fdc299 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
s4:torture/smb2: make it possible to pass existing_conn to smb2_connect_ext() 2023-08-08T12:57:29+00:00 Stefan Metzmacher metze@samba.org 2023-08-07T10:22:43+00:00 2b93058be3f6e5eaee239ad3b0e707c62089d18e BUG: https://bugzilla.samba.org/show_bug.cgi?id=15346 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15346

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 smbXcli: Pass negotiate contexts through smbXcli_negprot_send/recv 2022-08-26T19:54:03+00:00 Volker Lendecke vl@samba.org 2022-08-25T07:54:52+00:00 4ddd277c0b77c502ed6b11e07c92c91f24ac9c15 We already don't allow setting max_credits in the sync wrapper, so omit the contexts there as well. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Aug 26 19:54:03 UTC 2022 on sn-devel-184 
We already don't allow setting max_credits in the sync wrapper, so
omit the contexts there as well.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Aug 26 19:54:03 UTC 2022 on sn-devel-184
s4/libcli/smb2: avoid using smb2_composite_setpathinfo() in smb2_util_setatr() 2022-08-23T11:52:29+00:00 Ralph Boehme slow@samba.org 2022-08-14T16:51:30+00:00 66e40690bdd41800a01333ce4243bd62ee2b1894 smb2_composite_setpathinfo() uses SEC_FLAG_MAXIMUM_ALLOWED which can have unwanted side effects like breaking oplocks if the effective access includes [READ|WRITE]_DATA. For changing the DOS attributes we only need SEC_FILE_WRITE_ATTRIBUTE. With this change test_smb2_oplock_batch25() doesn't trigger an oplock break anymore. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15153 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> 
smb2_composite_setpathinfo() uses SEC_FLAG_MAXIMUM_ALLOWED which can
have unwanted side effects like breaking oplocks if the effective access
includes [READ|WRITE]_DATA.

For changing the DOS attributes we only need SEC_FILE_WRITE_ATTRIBUTE. With this
change test_smb2_oplock_batch25() doesn't trigger an oplock break anymore.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15153

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
lib/util: Change function to mem_equal_const_time() 2022-06-09T22:49:29+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2022-05-11T00:07:43+00:00 feb36dbebf1f0f48f4d9f2549471d355b4ead788 Since memcmp_const_time() doesn't act as an exact replacement for memcmp(), and its return value is only ever compared with zero, simplify it and emphasize the intention of checking equality by returning a bool instead. Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Since memcmp_const_time() doesn't act as an exact replacement for
memcmp(), and its return value is only ever compared with zero, simplify
it and emphasize the intention of checking equality by returning a bool
instead.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
libcli/smb: pass smb3_capabilities to smbXcli_conn_create() 2021-03-17T00:49:32+00:00 Stefan Metzmacher metze@samba.org 2021-03-09T22:49:19+00:00 c34b86a34e8ead6d52994b9b5b32f5553a8f90fd Passing NULL means use none. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14512 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Passing NULL means use none.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14512

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
libcli: Use GUID_to_ndr_buf() in smb2_create_send() 2020-10-02T21:30:34+00:00 Volker Lendecke vl@samba.org 2020-09-29T08:45:52+00:00 39180ca2d8932946aee3327668966098b9f229e0 Avoid talloc/free Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> 
Avoid talloc/free

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
s4:libcli: Require signing for SMB encryption 2020-08-19T16:22:43+00:00 Andreas Schneider asn@samba.org 2020-07-24T08:18:52+00:00 81052e41da82041cd32f3f7f3f20fd52ffb7e491 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>