samba.git/source4/libcli, branch talloc-2.3.0

s4/libcli/raw: Fix 'Value stored to 'p' is never read'

2019-07-16T22:52:24+00:00

Fixes:

source4/libcli/raw/clitree.c:138:3: warning: Value stored to 'p' is never read <--[clang]
                p += smbcli_req_pull_string(&req->in.bufinfo, mem_ctx, &parms->tconx.out.fs_type,
                ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

s4/libcli/raw: clang: Fix 'initialization value is never read'

2019-07-16T22:52:24+00:00

Fixes:

source4/libcli/raw/rawnegotiate.c:157:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_INTERNAL_ERROR;
                 ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

s4/libcli: clang: Fix 'initialization value is never read'

2019-07-16T22:52:24+00:00

Fixes:

source4/libcli/smb_composite/fetchfile.c:91:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                 ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

s4/libcli/ldab: clang: Fix 'Access results in a deref of a null pointer'

2019-07-16T22:52:24+00:00

Fixes:

source4/libcli/ldap/ldap_client.c:1023:6: warning: Access to field 'type' results in a dereference of a null pointer <--[clang]
        if ((*msg)->type != type) {
            ^~~~~~~~~~~~

Signed-off-by: Noel Power 
Reviewed-by: Gary Lockyer

source4: Update all consumers of strtoul_err(), strtoull_err() to new API

2019-06-30T11:32:18+00:00

Signed-off-by: Swen Schillig 
Reviewed-by: Ralph Boehme 
Reviewed-by: Christof Schmitt

lib/crypto: move gnutls error wrapper to own subsystem

2019-06-27T12:54:22+00:00

Signed-off-by: Andrew Bartlett 
Reviewed-by: Andreas Schneider

s4:libcli: Use gnutls_error_to_ntstatus() or singing

2019-06-24T06:11:16+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

Fix ubsan null pointer passed as argument 2

2019-05-27T01:29:48+00:00

Fix ubsan warning null pointer passed as argument 2 when the source
pointer is NULL.  The calls to memcpy are now guarded by an
if (len > 0)

Signed-off-by: Gary Lockyer 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Gary Lockyer 
Autobuild-Date(master): Mon May 27 01:29:48 UTC 2019 on sn-devel-184

libcli/ldap: Remove unsued ldap_transaction()

2019-05-22T05:59:14+00:00

This is unsued since a87dea2a0894015cf4a3140995791f5468c40038 in 2007
when we moved to using LDB for LDAP in this area of the code.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer

s3:libcli: Use GnuTLS MD5 for smb singing

2019-05-21T00:03:22+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett