samba.git/source4/libcli, branch talloc-2.3.4

s4:libcli: Covscan: unchecked return value for file_save()

2022-05-14T03:49:32+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Jeremy Allison 
Reviewed-by: Douglas Bagnall

s4:libcli: Fix trailing whitespace in browse.c

2022-05-14T03:49:32+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Jeremy Allison 
Reviewed-by: Douglas Bagnall

s4:libcli: Covscan: unchecked return value for file_save()

2022-05-14T03:49:32+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Jeremy Allison 
Reviewed-by: Douglas Bagnall

s4:libcli: Fix trailing whitespace in netlogon.c

2022-05-14T03:49:32+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Jeremy Allison 
Reviewed-by: Douglas Bagnall

dsdb: Return dsdb_password_change control name to DSDB_CONTROL_PASSWORD_CHANGE_OLD_PW_CHECKED_OID

2022-03-17T01:57:38+00:00

This makes it clearer that the purpose of this control is to indicate that the password
was already checked (by an out-of-band mechanism, eg kpasswd) and so can safely be changed
subject to ACLs etc.

This essentially reverts bbb9dc806e4399c65dee9b5dc2cde0bfaa9609bd

Signed-off-by: Andrew Bartlett 
Reviewed-by: Stefan Metzmacher

util: Drop unused variable num_received

2022-02-17T18:12:51+00:00

clang complains:

../../source4/libcli/clilist.c:111:6: error: variable 'num_received' set but not used [-Werror,-Wunused-but-set-variable]
        int num_received = 0;
            ^
../../source4/libcli/clilist.c:268:6: error: variable 'num_received' set but not used [-Werror,-Wunused-but-set-variable]
        int num_received = 0;
            ^

That is, the variable is initialised and updated but the value is
never used.

Signed-off-by: Martin Schwenke 
Reviewed-by: Volker Lendecke

s4: libcli: smbcli_unlink() is no longer used with wildcard patterns.

2021-12-09T18:06:35+00:00

Signed-off-by: Jeremy Allison 
Reviewed-by: Ralph Boehme

s4: libcli: In smbcli_deltree() use smbcli_unlink_wcard() in place of smbcli_unlink().

2021-12-09T18:06:35+00:00

We know we have a wildcard mask here.

Signed-off-by: Jeremy Allison 
Reviewed-by: Ralph Boehme

s4: libcli: Add smbcli_unlink_wcard().

2021-12-09T18:06:35+00:00

We will use this in place of smbcli_unlink() when we
know we are using a wildcard pattern. If can be used
to generally replace smbcli_unlink() as it calls down
to smbcli_unlink() is no wildcard is detected.

Signed-off-by: Jeremy Allison 
Reviewed-by: Ralph Boehme

libcli4: Remove outdated README file

2021-11-11T19:08:37+00:00

This has not materialized since 2005. We can easily add it once we
create libsmbclient4.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison