samba.git/source4/libcli, branch talloc-2.4.0

s3-librpc: add ads.idl and convert ads_struct to talloc.

2022-12-16T20:38:32+00:00

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Jeremy Allison

s4: libcli: Ignore errors when getting A records after fetching AAAA records.

2022-11-09T20:34:07+00:00

The target may only be available over IPv6.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15226

Signed-off-by: Jeremy Allison 
Reviewed-by: Stefan Metzmacher 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Nov  9 20:34:07 UTC 2022 on sn-devel-184

build: Remove unused dependencies

2022-11-08T02:39:37+00:00

We don't need to include these any more, and removing them allows us to
simplify the build system for system Heimdal builds.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

CVE-2020-25720: s4-acl: Change behavior of Create Children check

2022-09-16T02:32:36+00:00

Up to now, the rights to modify an attribute were not checked during an LDAP
add operation. This means that even if a user has no right to modify
an attribute, they can still specify any value during object creation,
and the validated writes were not checked.
This patch changes this behavior. During an add operation,
a security descriptor is created that does not include the one provided by the
user, and is used to verify that the user has the right to modify the supplied attributes.
Exception is made for an object's mandatory attributes, and if the user has Write DACL right,
further checks are skipped.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14810

Pair-Programmed-With: Joseph Sutton 

Signed-off-by: Nadezhda Ivanova 
Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

smbXcli: Pass negotiate contexts through smbXcli_negprot_send/recv

2022-08-26T19:54:03+00:00

We already don't allow setting max_credits in the sync wrapper, so
omit the contexts there as well.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Aug 26 19:54:03 UTC 2022 on sn-devel-184

s4/libcli/smb2: avoid using smb2_composite_setpathinfo() in smb2_util_setatr()

2022-08-23T11:52:29+00:00

smb2_composite_setpathinfo() uses SEC_FLAG_MAXIMUM_ALLOWED which can
have unwanted side effects like breaking oplocks if the effective access
includes [READ|WRITE]_DATA.

For changing the DOS attributes we only need SEC_FILE_WRITE_ATTRIBUTE. With this
change test_smb2_oplock_batch25() doesn't trigger an oplock break anymore.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15153

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher

lib/util: Change function to mem_equal_const_time()

2022-06-09T22:49:29+00:00

Since memcmp_const_time() doesn't act as an exact replacement for
memcmp(), and its return value is only ever compared with zero, simplify
it and emphasize the intention of checking equality by returning a bool
instead.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

auth: Use constant-time memcmp when comparing sensitive buffers

2022-06-09T22:49:29+00:00

This helps to avoid timing attacks.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15010

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s4:libcli: Covscan: unchecked return value for file_save()

2022-05-14T03:49:32+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Jeremy Allison 
Reviewed-by: Douglas Bagnall

s4:libcli: Fix trailing whitespace in browse.c

2022-05-14T03:49:32+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Jeremy Allison 
Reviewed-by: Douglas Bagnall