samba.git/source4/libnet/libnet_vampire.c, branch master

s4-libnet: Split up samba-net into samba-net and samba-net-join

2024-06-05T20:42:34+00:00

samba-net-join links to python and so needs the variable name
with the python ABI tag, while samba-net is a normal C library
and can be included in a package without python dependencies.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Alexander Bokovoy

s4:libnet: Add missing newlines to logging messages

2023-08-08T04:39:38+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s4:libnet: Fix uninitialized value "seq_num"

2022-01-26T11:44:32+00:00

Found by covscan.

Signed-off-by: Pavel Filipenský 
Reviewed-by: Volker Lendecke 
Reviewed-by: Andreas Schneider

s4:libnet: Fix trailing whitespace in libnet_vampire.c

2022-01-26T11:44:32+00:00

Signed-off-by: Pavel Filipenský 
Reviewed-by: Volker Lendecke 
Reviewed-by: Andreas Schneider

provision: Decrease the length of random machine passwords

2021-04-07T09:18:30+00:00

The current length of 128-255 UTF-16 characters currently causes
generation of crypt() passwords to typically fail. This commit
decreases the length to 120 UTF-16 characters, which is the same as
that used by Windows.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14621

Signed-off-by: Joseph Sutton 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

s4/libnet: Fix joining a Windows pre-2008R2 DC

2019-07-04T22:49:23+00:00

From v4.8 onwards, Samba may not be able join a DC older than 2008R2
because the Windows DC doesn't support GET_TGT.

If the dsdb repl_md code can't resolve a link target it returns an
error, and the calling code (e.g. drs_util.py) should retry with
GET_TGT. However, GET_TGT is only supported on Windows 2008R2 and later,
so if you try to join an earlier Windows DC, the join will throw an
error that you can't work-around.

We can avoid this problem by setting the same DSDB flag that GET_TGT
sets to indicate that the link targets are as up-to-date as possible,
and so there's no point retrying. Missing targets are still logged, so
this at least allows the admin to fix up any problems after the join
completed.

I've only done this for the join case (problems during periodic
replication are probably still worth escalating to an error).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14021
RN: From Samba v4.8 onwards, joining a Windows 2003 or 2008 (non-R2) AD
DC may not have worked. When this problem occurred, the following
message would be displayed:
 'Failed to commit objects: DOS code 0x000021bf'
This particular issue has now been resolved. Note that there may still
be other potential problems that occur when joining an older Windows DC.

Signed-off-by: Tim Beale 
Reviewed-by: Andrew Bartlett

libnet vampire: NULL access bug fix

2019-04-08T02:07:22+00:00

NULL pointer access bug fix

Signed-off-by: Garming Sam 
Signed-off-by: Aaron Haslett 
Reviewed-by: Andrew Bartlett

s4/param: Fix provision_get_schema leaking python object

2019-02-21T03:09:19+00:00

provision_get_schema returns a ldb_context object which is stored
in a python object. As a result the parent python object is never
decrefed and probably not released ever.

Signed-off-by: Noel Power 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

libnet: Reset debug counters after replicating critical objects

2018-11-06T02:39:11+00:00

Reset the debug counters once we have finished replicating a given
partition. This helps if we replicate the same partition immediately
afterward with different options.

This helps the DC join debug look less weird. Because it replicates the
critical objects first, and then the base partition, previously it
always ended up overcounting, e.g.

Partition[DC=addom,DC=samba,DC=example,DC=com] objects[314/218]
  linked_values[48/24]

Signed-off-by: Tim Beale 
Reviewed-by: Andrew Bartlett

libnet/drs: Update replication debug to report link progress

2018-10-17T03:40:07+00:00

Update the replication debug (for joins/backups) so that it's easier to
see how far through syncing the links we are. E.g. with 150,000 links,
you just get screeds of debug like this, with no real idea how far
through the replication is.

Partition[DC=addom,DC=samba,DC=example,DC=com] objects[11816/11720]
linked_values[1500/150024]
Partition[DC=addom,DC=samba,DC=example,DC=com] objects[11816/11720]
linked_values[1500/150024]
Partition[DC=addom,DC=samba,DC=example,DC=com] objects[11816/11720]
linked_values[1500/150024]

This patch now applies to links the same debug logic we use for objects,
and changes it to look like:

Partition[DC=addom,DC=samba,DC=example,DC=com] objects[11816/11720]
linked_values[57024/150024]
Partition[DC=addom,DC=samba,DC=example,DC=com] objects[11816/11720]
linked_values[58524/150024]
Partition[DC=addom,DC=samba,DC=example,DC=com] objects[11816/11720]
linked_values[60024/150024]

Signed-off-by: Tim Beale 
Reviewed-by: Garming Sam 
Reviewed-by: Andrew Bartlett