samba.git/source4/libnet/py_net.c, branch talloc-2.4.0

CVE-2022-37966 s4:libnet: allow python bindings to force setting an nthash via SAMR level 18

2022-12-13T13:07:30+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15237

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s4:libnet:py_net - free event context in dealloc fn

2020-11-06T04:58:31+00:00

Creation of a new Net() object initializes an event context under
a NULL talloc context and then creates a new talloc context as a
child of the event context. The deallocation function for the
net object only frees the child and not the parent. This leaks an
fd for the tevent context and associated memory.

Signed-off-by: Andrew Walker 
Reviewed-by: Jeremy Allison 
Reviewed-by: Gary Lockyer 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Nov  6 04:58:31 UTC 2020 on sn-devel-184

py3: Remove PyStr_FromString() compatability macro

2019-06-24T17:24:27+00:00

We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Noel Power

s4: squash 'cast between incompatible function types' warning

2019-05-16T17:55:17+00:00

To avoid warning above produced by using
 -Wcast-function-type we;

  + ensure PyCFunctions of type METH_NOARGS defined dummy arg
  + ensure PyCFunctions of type METH_KEYWORDS use PY_DISCARD_FUNC_SIG
    macro
  + ensure PyCFunctions of type METH_KEYWORDS really actually use the
    problematic kargs param, if not remove it

Signed-off-by: Noel Power 
Reviewed-by: Andreas Schneider

Make sure results from GetAttrString are decref'ed where needed

2019-02-13T13:51:12+00:00

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett abartlet@samba.org

Autobuild-User(master): Noel Power 
Autobuild-Date(master): Wed Feb 13 14:51:12 CET 2019 on sn-devel-144

Cleanup references to module objects returned from PyImport_ImportModule

2019-02-07T12:44:30+00:00

Signed-off-by: Noel Power 
Reviewed-by: Douglas Bagnall

py_net: fix != None check

2019-02-01T02:36:17+00:00

Py_None is not false in C, so this branch was always taken.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

s4/libnet: use 'et' as format for ParseTuple with python2

2019-01-12T23:40:26+00:00

Signed-off-by: Noel Power 
Reviewed-by: Douglas Bagnall

FIXUP: Improve memory handling on py_net_change_password

2018-05-17T12:28:19+00:00

Signed-off-by: Andrew Bartlett 
Reviewed-by: Noel Power 

Autobuild-User(master): Noel Power 
Autobuild-Date(master): Thu May 17 14:28:19 CEST 2018 on sn-devel-144

s4/libnet: Allow passwords containing non ascii characters to be passed

2018-05-17T09:31:28+00:00

Although we can pass unicode to py_net_change_password unfortunately in
Python2 unicode strings are encoded with the default encoding (e.g. ascii)
 when extracting the unicode string to buffer.
In Python3 the default encoding for "s" format is utf8. Use the "es"
format instead of "s" so we can specify the encoding so behaviour is
correct in py2/py3.

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett