samba.git/source4/libnet, branch talloc-2.3.3

provision: Decrease the length of random machine passwords

2021-04-07T09:18:30+00:00

The current length of 128-255 UTF-16 characters currently causes
generation of crypt() passwords to typically fail. This commit
decreases the length to 120 UTF-16 characters, which is the same as
that used by Windows.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14621

Signed-off-by: Joseph Sutton 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

s4:libnet_rpc: avoid reusing the assoc_group_id of the lsa connection

2021-03-11T22:50:02+00:00

This was an unexpected side effect introduced in commit
1b17d9a587bf3600d449c2481fe1191793479e32.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Mar 11 22:50:02 UTC 2021 on sn-devel-184

s4:libnet:py_net - free event context in dealloc fn

2020-11-06T04:58:31+00:00

Creation of a new Net() object initializes an event context under
a NULL talloc context and then creates a new talloc context as a
child of the event context. The deallocation function for the
net object only frees the child and not the parent. This leaks an
fd for the tevent context and associated memory.

Signed-off-by: Andrew Walker 
Reviewed-by: Jeremy Allison 
Reviewed-by: Gary Lockyer 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Nov  6 04:58:31 UTC 2020 on sn-devel-184

smbdes: convert E_old_pw_hash to use gnutls

2019-12-10T00:30:31+00:00

Signed-off-by: Isaac Boukris 
Reviewed-by: Andrew Bartlett

s4:libnet: Use GnuTLS RC4 in libnet_ChangePassword_samr()

2019-07-26T01:48:23+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031

Signed-off-by: Andreas Schneider 
Signed-off-by: Andrew Bartlett 
Reviewed-by: Andrew Bartlett

s4:libnet: Use GnuTLS RC4 in libnet_SetPassword_samr_handle_23()

2019-07-26T01:48:23+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

s4:libnet: Use GnuTLS RC4 in libnet_SetPassword_samr_handle_24()

2019-07-26T01:48:23+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

s4:libnet: Use encode_rc4_passwd_buffer() in libnet_SetPassword_samr_handle_25()

2019-07-26T01:48:23+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

s4:libnet: Use encode_rc4_passwd_buffer() in libnet_SetPassword_samr_handle_26()

2019-07-26T01:48:23+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

s4/libnet: Fix joining a Windows pre-2008R2 DC

2019-07-04T22:49:23+00:00

From v4.8 onwards, Samba may not be able join a DC older than 2008R2
because the Windows DC doesn't support GET_TGT.

If the dsdb repl_md code can't resolve a link target it returns an
error, and the calling code (e.g. drs_util.py) should retry with
GET_TGT. However, GET_TGT is only supported on Windows 2008R2 and later,
so if you try to join an earlier Windows DC, the join will throw an
error that you can't work-around.

We can avoid this problem by setting the same DSDB flag that GET_TGT
sets to indicate that the link targets are as up-to-date as possible,
and so there's no point retrying. Missing targets are still logged, so
this at least allows the admin to fix up any problems after the join
completed.

I've only done this for the join case (problems during periodic
replication are probably still worth escalating to an error).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14021
RN: From Samba v4.8 onwards, joining a Windows 2003 or 2008 (non-R2) AD
DC may not have worked. When this problem occurred, the following
message would be displayed:
 'Failed to commit objects: DOS code 0x000021bf'
This particular issue has now been resolved. Note that there may still
be other potential problems that occur when joining an older Windows DC.

Signed-off-by: Tim Beale 
Reviewed-by: Andrew Bartlett