samba.git/source4/param/provision.c, branch master

Use python.h from libreplace

2023-11-20T15:37:33+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15513

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

s4:param: Add missing newlines to logging messages

2023-08-08T04:39:38+00:00

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett

s4:param: replace calls to deprecated Python methods

2023-07-21T01:25:36+00:00

Replace calls to (obsolete but still stable)
PyEval_CallObjectWithKeywords() with PyObject_Call()
by using trivial wrapper.

Signed-off-by: Dmitry Antipov 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

[abartlet@samba.org Adjusted to always use the PyObject_Call()
 as it is available in all of Samba's supported python versions]

py3: Remove #define PyInt_FromLong PyLong_FromLong

2020-03-23T19:12:43+00:00

This allows us to end the use of Python 2/3 compatability macros.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Noel Power

s4/param: py_sid shouldn't be decref'ed after insertion into dict

2020-03-19T22:23:52+00:00

This was causing samba.tests.net_join_no_spnego(ad_dc) to
core dumps sometimes on tumbleweed with python3.8

with...

===============================================================
INTERNAL ERROR: Signal 11 in pid 1781 (4.12.0)
If you are running a recent Samba version, and if you think this problem is not yet fixed in the latest versions, please consider reporting this bug, see https://wiki.samba.org/index.php/Bug_Reporting
===============================================================
smb_panic_default: PANIC (pid 1781): internal error
BACKTRACE: 64 stack frames:

7128  #0 bin/shared/libsamba-util.so.0(log_stack_trace+0x1f) [0x7fa541c5b220]
7129  #1 bin/shared/libsamba-util.so.0(+0x1efc8) [0x7fa541c5afc8]
7130  #2 bin/shared/libsamba-util.so.0(log_stack_trace+0) [0x7fa541c5b201]
7131  #3 bin/shared/libsamba-util.so.0(+0x1eed9) [0x7fa541c5aed9]
7132  #4 bin/shared/libsamba-util.so.0(+0x1eeee) [0x7fa541c5aeee]
7133  #5 /lib64/libc.so.6(+0x3bf20) [0x7fa542631f20]
7134  #6 /usr/lib64/libpython3.8.so.1.0(PyObject_GC_UnTrack+0xd) [0x7fa542386c1d]
7135  #7 /usr/lib64/libpython3.8.so.1.0(+0x12d599) [0x7fa542387599]
7136  #8 /usr/lib64/libpython3.8.so.1.0(_PyEval_EvalFrameDefault+0x4d6d) [0x7fa5424269ed]
7137  #9 /usr/lib64/libpython3.8.so.1.0(_PyEval_EvalCodeWithName+0x30c) [0x7fa5423eaf5c]
7138  #10 /usr/lib64/libpython3.8.so.1.0(_PyFunction_Vectorcall+0x18e) [0x7fa5423ebcbe]
7139  #11 /usr/lib64/libpython3.8.so.1.0(_PyEval_EvalFrameDefault+0x4a3a) [0x7fa5424266ba]
etc....

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Thu Mar 19 22:23:52 UTC 2020 on sn-devel-184

s4/param: treat NULL value passed to dict_insert as error

2020-03-19T20:46:42+00:00

insert_dict is used as a convenience to decrement the values to
prevent leaks with orpahaned PyObjects and avoid excessive creation of
temp variables.

        if (!dict_insert(parameters,
                         "rootdn",
                         PyUnicode_FromString(settings->root_dn_str))) {
                status = NT_STATUS_UNSUCCESSFUL;
                goto out;
        }

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett

s4/param: don't decref object we don't own

2020-03-19T20:46:42+00:00

provision_fn is a borrowed reference we should not
call Py_CLEAR on it

Signed-off-by: Noel Power 
Reviewed-by: Andrew Bartlett

s4:param: make use of secrets_db_create() in provision_store_self_join()

2020-02-05T08:46:39+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider

py3: Remove PyStr_AsString() compatability macro

2019-06-24T17:24:27+00:00

We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Noel Power

py3: Remove PyStr_FromString() compatability macro

2019-06-24T17:24:27+00:00

We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Noel Power