<feed xmlns='http://www.w3.org/2005/Atom'>
<title>samba.git/source4/param, branch talloc-2.3.0</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.</subtitle>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/'/>
<entry>
<title>py3: Remove duplicated PyUnicode_Check() after the py3 compat macros were removed</title>
<updated>2019-06-24T18:48:53+00:00</updated>
<author>
<name>Andrew Bartlett</name>
<email>abartlet@samba.org</email>
</author>
<published>2019-06-15T11:14:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=4f32983ea8a24466165c043a73cb47b4073da15f'/>
<id>4f32983ea8a24466165c043a73cb47b4073da15f</id>
<content type='text'>
This came about because in py2 we had to check for strings and unicode.

Signed-off-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
Reviewed-by: Noel Power &lt;noel.power@suse.com&gt;

Autobuild-User(master): Noel Power &lt;npower@samba.org&gt;
Autobuild-Date(master): Mon Jun 24 18:48:53 UTC 2019 on sn-devel-184
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This came about because in py2 we had to check for strings and unicode.

Signed-off-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
Reviewed-by: Noel Power &lt;noel.power@suse.com&gt;

Autobuild-User(master): Noel Power &lt;npower@samba.org&gt;
Autobuild-Date(master): Mon Jun 24 18:48:53 UTC 2019 on sn-devel-184
</pre>
</div>
</content>
</entry>
<entry>
<title>py3: Remove PyStr_AsString() compatability macro</title>
<updated>2019-06-24T17:24:27+00:00</updated>
<author>
<name>Andrew Bartlett</name>
<email>abartlet@samba.org</email>
</author>
<published>2019-06-07T09:16:25+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=f178daa854dc4ea9cb917d17cd4c8a876356e981'/>
<id>f178daa854dc4ea9cb917d17cd4c8a876356e981</id>
<content type='text'>
We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
Reviewed-by: Noel Power &lt;noel.power@suse.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
Reviewed-by: Noel Power &lt;noel.power@suse.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>py3: Remove PyStr_FromFormat() compatability macro</title>
<updated>2019-06-24T17:24:27+00:00</updated>
<author>
<name>Andrew Bartlett</name>
<email>abartlet@samba.org</email>
</author>
<published>2019-06-07T09:08:55+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=75d87b29f11a1dacb37ccc1b10f8d034063ef5ba'/>
<id>75d87b29f11a1dacb37ccc1b10f8d034063ef5ba</id>
<content type='text'>
We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
Reviewed-by: Noel Power &lt;noel.power@suse.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
Reviewed-by: Noel Power &lt;noel.power@suse.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>py3: Remove PyStr_FromString() compatability macro</title>
<updated>2019-06-24T17:24:27+00:00</updated>
<author>
<name>Andrew Bartlett</name>
<email>abartlet@samba.org</email>
</author>
<published>2019-06-07T08:45:52+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=34f9a089d8d3a8971b2f7ee45f6d8e823a52a193'/>
<id>34f9a089d8d3a8971b2f7ee45f6d8e823a52a193</id>
<content type='text'>
We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
Reviewed-by: Noel Power &lt;noel.power@suse.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
Reviewed-by: Noel Power &lt;noel.power@suse.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>py3: Remove PyStr_Check() compatability macro</title>
<updated>2019-06-24T17:24:27+00:00</updated>
<author>
<name>Andrew Bartlett</name>
<email>abartlet@samba.org</email>
</author>
<published>2019-06-07T08:39:11+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=f498c819664e9df658651d39f616f5b4d62b4750'/>
<id>f498c819664e9df658651d39f616f5b4d62b4750</id>
<content type='text'>
We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
Reviewed-by: Noel Power &lt;noel.power@suse.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We no longer need Samba to be py2/py3 compatible so we choose to return to the standard
function names.

Signed-off-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
Reviewed-by: Noel Power &lt;noel.power@suse.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>s4: squash 'cast between incompatible function types' warning</title>
<updated>2019-05-16T17:55:17+00:00</updated>
<author>
<name>Noel Power</name>
<email>noel.power@suse.com</email>
</author>
<published>2019-05-02T18:45:14+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=a7d75a1c57befee4a178b7061ea218e353a72195'/>
<id>a7d75a1c57befee4a178b7061ea218e353a72195</id>
<content type='text'>
To avoid warning above produced by using
 -Wcast-function-type we;

  + ensure PyCFunctions of type METH_NOARGS defined dummy arg
  + ensure PyCFunctions of type METH_KEYWORDS use PY_DISCARD_FUNC_SIG
    macro
  + ensure PyCFunctions of type METH_KEYWORDS really actually use the
    problematic kargs param, if not remove it

Signed-off-by: Noel Power &lt;noel.power@suse.com&gt;
Reviewed-by: Andreas Schneider &lt;asn@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
To avoid warning above produced by using
 -Wcast-function-type we;

  + ensure PyCFunctions of type METH_NOARGS defined dummy arg
  + ensure PyCFunctions of type METH_KEYWORDS use PY_DISCARD_FUNC_SIG
    macro
  + ensure PyCFunctions of type METH_KEYWORDS really actually use the
    problematic kargs param, if not remove it

Signed-off-by: Noel Power &lt;noel.power@suse.com&gt;
Reviewed-by: Andreas Schneider &lt;asn@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>build: Remove bld.gen_python_environments()</title>
<updated>2019-03-21T04:06:14+00:00</updated>
<author>
<name>Andrew Bartlett</name>
<email>abartlet@samba.org</email>
</author>
<published>2019-02-15T03:37:48+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=fdb6305c861a088f797d29889c51c0553cc048be'/>
<id>fdb6305c861a088f797d29889c51c0553cc048be</id>
<content type='text'>
This was part of --extra-python support.

Signed-off-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
Reviewed-by: Garming Sam &lt;garming@catalyst.net.nz&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This was part of --extra-python support.

Signed-off-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
Reviewed-by: Garming Sam &lt;garming@catalyst.net.nz&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>s4/param: Fix provision_get_schema leaking python object</title>
<updated>2019-02-21T03:09:19+00:00</updated>
<author>
<name>Noel Power</name>
<email>noel.power@suse.com</email>
</author>
<published>2019-02-15T10:04:23+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=5f9a5ef262b4700b47bfb931b6b096f56aa56b15'/>
<id>5f9a5ef262b4700b47bfb931b6b096f56aa56b15</id>
<content type='text'>
provision_get_schema returns a ldb_context object which is stored
in a python object. As a result the parent python object is never
decrefed and probably not released ever.

Signed-off-by: Noel Power &lt;noel.power@suse.com&gt;
Reviewed-by: Douglas Bagnall &lt;douglas.bagnall@catalyst.net.nz&gt;
Reviewed-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
provision_get_schema returns a ldb_context object which is stored
in a python object. As a result the parent python object is never
decrefed and probably not released ever.

Signed-off-by: Noel Power &lt;noel.power@suse.com&gt;
Reviewed-by: Douglas Bagnall &lt;douglas.bagnall@catalyst.net.nz&gt;
Reviewed-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Make sure results from GetAttrString are decref'ed where needed</title>
<updated>2019-02-13T13:51:12+00:00</updated>
<author>
<name>Noel Power</name>
<email>noel.power@suse.com</email>
</author>
<published>2019-01-28T16:57:17+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=0c15c4b1db9ef12cc02683bbf24e0a2d10d1b991'/>
<id>0c15c4b1db9ef12cc02683bbf24e0a2d10d1b991</id>
<content type='text'>
Signed-off-by: Noel Power &lt;noel.power@suse.com&gt;
Reviewed-by: Andrew Bartlett abartlet@samba.org

Autobuild-User(master): Noel Power &lt;npower@samba.org&gt;
Autobuild-Date(master): Wed Feb 13 14:51:12 CET 2019 on sn-devel-144
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Noel Power &lt;noel.power@suse.com&gt;
Reviewed-by: Andrew Bartlett abartlet@samba.org

Autobuild-User(master): Noel Power &lt;npower@samba.org&gt;
Autobuild-Date(master): Wed Feb 13 14:51:12 CET 2019 on sn-devel-144
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix instances of PyDict_SetItem to decref the value</title>
<updated>2019-02-13T10:42:09+00:00</updated>
<author>
<name>Noel Power</name>
<email>noel.power@suse.com</email>
</author>
<published>2019-01-28T15:23:59+00:00</published>
<link rel='alternate' type='text/html' href='https://git.exis.tech/samba.git/commit/?id=8d3f736bba3367ed615f97d292f86c447a25b8d5'/>
<id>8d3f736bba3367ed615f97d292f86c447a25b8d5</id>
<content type='text'>
Although it would be better to use the BuildValue approach to
create the dictionares here, unfortunately the dictionaries created
here have key/values that are created dynamically (based on input params).

Signed-off-by: Noel Power &lt;noel.power@suse.com&gt;
Reviewed-by: Andrew Bartlett abartlet@samba.org
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Although it would be better to use the BuildValue approach to
create the dictionares here, unfortunately the dictionaries created
here have key/values that are created dynamically (based on input params).

Signed-off-by: Noel Power &lt;noel.power@suse.com&gt;
Reviewed-by: Andrew Bartlett abartlet@samba.org
</pre>
</div>
</content>
</entry>
</feed>
