samba.git/source4/rpc_server/drsuapi, branch master Unnamed repository; edit this file 'description' to name the repository. s4: s/the the\b/the/ in miscellaneous comments 2024-11-06T10:57:35+00:00 Douglas Bagnall douglas.bagnall@catalyst.net.nz 2024-09-13T02:30:42+00:00 26dd542928ce8e26cd47439564db891810c5f058 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Volker Lendecke <vl@samba.org> 
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Volker Lendecke <vl@samba.org>
s4:drsuapi:getncchanges: allow 0 reserved_usn reply 2024-08-28T04:24:39+00:00 Douglas Bagnall douglas.bagnall@catalyst.net.nz 2024-08-07T05:25:30+00:00 7a623d8d5626b4e6c88ffb85e36f0934d89ed830 Azure AD will set reserved_usn to zero when we expect it to be the number we gave them. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15701 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jennifer Sutton <josutton@catalyst.net.nz> 
Azure AD will set reserved_usn to zero when we expect it to be
the number we gave them.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15701

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <josutton@catalyst.net.nz>
s4:drsuapi:getncchanges: use DBG_ERR() macro 2024-08-28T04:24:39+00:00 Douglas Bagnall douglas.bagnall@catalyst.net.nz 2024-06-13T05:23:23+00:00 5ef27019033fd73decd111f9426e7f8982cbb806 The next commit will indent this more, so it's a bit squished up. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15701 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jennifer Sutton <josutton@catalyst.net.nz> 
The next commit will indent this more, so it's a bit squished up.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15701

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <josutton@catalyst.net.nz>
s4:drsuapi:getncchanges: fix whitespace 2024-08-28T04:24:39+00:00 Douglas Bagnall douglas.bagnall@catalyst.net.nz 2024-08-07T05:05:48+00:00 2e1ccb35239fc6fe129c943bb7305bd4612d72d7 BUG: https://bugzilla.samba.org/show_bug.cgi?id=15701 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jennifer Sutton <josutton@catalyst.net.nz> 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15701

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <josutton@catalyst.net.nz>
s4:rpc_srv:getncchanges: USN sort uses qsort() instead of ldb_qsort() 2024-05-07T23:25:35+00:00 Douglas Bagnall douglas.bagnall@catalyst.net.nz 2024-04-12T06:33:47+00:00 c5c29f59fa6baa1564a7fde55e2b0639a6a8a39c Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
s4:rpc_srv:getncchanges: 4.5 anc emulation uses qsort(), not ldb_qsort() 2024-05-07T23:25:35+00:00 Douglas Bagnall douglas.bagnall@catalyst.net.nz 2024-04-12T06:32:42+00:00 65df8ce05c1d1bb9dd93592269ef966446cc5746 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
s4:rpc_server: Fix code spelling 2023-10-25T22:23:37+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2023-09-21T21:16:18+00:00 fc1fd9c656a7d41960fc13429fe61772ed794d98 Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
s4:rpc_server: Switch to using smb_krb5_princ_component() 2023-09-14T21:35:29+00:00 Joseph Sutton josephsutton@catalyst.net.nz 2023-09-05T04:46:17+00:00 7e62f3921f2d6776f857072b9f4dd2a3302a8bca Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
s4:rpc_server: Fix code spelling 2023-08-14T21:45:29+00:00 Andreas Schneider asn@samba.org 2023-08-03T12:40:26+00:00 8d85b9987eeb3bee54d4e51da98fd76f487dce93 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
s4-rpc_server/drsupai: Avoid looping with Azure AD Connect by not incrementing temp_highest_usn for the NC root 2023-08-13T21:59:29+00:00 Andrew Bartlett abartlet@samba.org 2023-07-26T02:27:16+00:00 79ca6ef28a6f94965cb030c4a7da8c1b9db7150b We send the NC root first, as a special case for every chunk that we send until the natural point where it belongs. We do not bump the tmp_highest_usn in the highwatermark that the client and server use (it is meant to be an opauqe cookie) until the 'natural' point where the object appears, similar to the cache for GET_ANC. The issue is that without this, because the NC root was sorted first in whatever chunk it appeared in but could have a 'high' highwatermark, Azure AD Connect will send back the same new_highwatermark->tmp_highest_usn, and due to a bug, a zero reserved_usn, which makes Samba discard it. The reserved_usn is now much less likely to ever be set because the tmp_higest_usn is now always advancing. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15401 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> 
We send the NC root first, as a special case for every chunk
that we send until the natural point where it belongs.

We do not bump the tmp_highest_usn in the highwatermark that
the client and server use (it is meant to be an opauqe cookie)
until the 'natural' point where the object appears, similar
to the cache for GET_ANC.

The issue is that without this, because the NC root was sorted
first in whatever chunk it appeared in but could have a 'high'
highwatermark, Azure AD Connect will send back the same
new_highwatermark->tmp_highest_usn, and due to a bug,
a zero reserved_usn, which makes Samba discard it.

The reserved_usn is now much less likely to ever be set because
the tmp_higest_usn is now always advancing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15401

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>