samba.git/source4/rpc_server/samr, branch talloc-2.2.0

s4 rpc_server_samr: DomGeneralInformation use dsdb_domain_count

2019-02-14T04:03:23+00:00

Use dsdb_domain_count instead of samdb_search_count to determine the
number of users, groups and aliases.  This gives a performance gain of
around 10%, reduces the total memory allocated and fixes the incorrect
count returned for aliases.

Signed-off-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett

s4:dsdb:util: export SAMBA_CPS_{ACCOUNT,USER_PRINCIPAL,FULL}_NAME for check password script

2019-02-11T06:43:32+00:00

This allows the check password script to reject the username and other
things.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

s4:rpc_server: only pass context to op_bind() hooks

2019-01-12T02:13:39+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

s4:rpc_server: only use context within op_bind() hooks and dcesrv_interface_bind_*() functions

2019-01-12T02:13:39+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

s4:rpc_server/samr: make use of dcesrv_call_auth_info()

2019-01-12T02:13:35+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

s4:rpc_server/samr: make use of dcesrv_handle_create()

2019-01-12T02:13:35+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

s4:rpc_server/samr: make use of dcesrv_transport_session_key()

2019-01-12T02:13:33+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

s4:rpc_server/samr: make use dcesrv_call_session_info()

2019-01-12T02:13:33+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

s4:rpc_server/samr: Fix the O3 developer build

2019-01-12T02:13:32+00:00

Different gcc versions complain at different places.

I recently got these:

../source4/rpc_server/samr/dcesrv_samr.c: In function
‘dcesrv_samr_QueryDisplayInfo2’:
../source4/rpc_server/samr/dcesrv_samr.c:4117:2: error: ‘q.out.result.v’
may be used uninitialized in this function [-Werror=maybe-uninitialized]
  return result;
  ^
../source4/rpc_server/samr/dcesrv_samr.c: In function
‘dcesrv_samr_QueryDisplayInfo3’:
../source4/rpc_server/samr/dcesrv_samr.c:4151:2: error: ‘q.out.result.v’
may be used uninitialized in this function [-Werror=maybe-uninitialized]
  return result;
  ^
cc1: all warnings being treated as errors

../source4/rpc_server/samr/dcesrv_samr.c: In function
‘dcesrv_samr_QueryDisplayInfo3’:
../source4/rpc_server/samr/dcesrv_samr.c:4151:2: error: ‘q.out.result.v’
may be used uninitialized in this function [-Werror=maybe-uninitialized]
  return result;
  ^
In file included from ../source4/rpc_server/samr/dcesrv_samr.c:4447:0:
default/librpc/gen_ndr/ndr_samr_s.c: In function ‘samr__op_dispatch’:
default/librpc/gen_ndr/ndr_samr_s.c:597:18: error: ‘q.out.result.v’ may
be used uninitialized in this function [-Werror=maybe-uninitialized]
   r2->out.result = dcesrv_samr_QueryDisplayInfo2(dce_call, mem_ctx,
r2);
                  ^
cc1: all warnings being treated as errors

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison

source4 samr: Tidy DBG_WARNING calls

2018-11-21T00:50:11+00:00

Move the calls to GUID_buf_string and dom_sid_str_buf into the
coresponding DBG_WARNING call, instead of using an intermediate variable.
While this violates the coding guidelines, doing this makes the code less
cluttred and means the functions are only called if the debug message is
printed.

Signed-off-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed Nov 21 01:50:11 CET 2018 on sn-devel-144