samba.git/source4/scripting, branch talloc-2.2.0

s4/scripting: remove obsolete w32err_code.py

2019-03-14T02:12:18+00:00

This has been replaced by gen_werror.py which shares common code with other scripts
(e.g. gen_ntstatus) and is more likely to work with conteporary microsoft HTML.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

s4/scripting: Remove legacy selftest-vars.sh script

2019-03-12T01:53:26+00:00

This script was added in 2010 and has only been sporadically kept
up-to-date since. It doesn't appear to work (I think that selftest
and the testenvs have perhaps grown in complexity since 2010 and it's no
longer possible to try to access a testenv from a different
process-space, due to how we use the cwrap libraries).

There's now an alternative (export_envvars_to_file()) in the selftest
code to regenerate a similar file, if anyone actually needs it.

Signed-off-by: Tim Beale 
Reviewed-by: Andrew Bartlett

selftest: Remove unused SELFTEST_INTERFACES

2019-03-12T01:53:26+00:00

This doesn't appear to be used anywhere and dates back to 2008.

Signed-off-by: Tim Beale 
Reviewed-by: Andrew Bartlett

s4/scripting/autoidl: p3 exception syntax

2019-03-12T00:42:18+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

s4/scripting: MORE py3 compatible print functions

2019-03-12T00:42:18+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett

selftest: Remove unused environment variables

2019-02-18T04:42:09+00:00

We only really want generic environment variables. For 2+ DC
environments, we have the $SERVER and $DC_SERVER (aka PDC) variables.
However, lots of testenvs also export really specific environment
variables, e.g. VAMPIRE_2000_DC_SERVER_IP (despite that testenv being
only used for a single test case).

Previously the _SERVER variable was used for DRS tests, but we
can avoid the need to do this now. The other variables are not used at
all.

The RODC and TRUST environment variables are still used by a few tests.
SUBDOM_DC_SERVER is only used within Samba4.pm and not exported.

Signed-off-by: Tim Beale 
Reviewed-by: Andrew Bartlett

sambaundoguididx: use the right escaped oder unescaped sam ldb files

2019-02-17T12:33:12+00:00

the correct filename is taken from the partition database before, we should not
unescape that because this can result in a new unescaped ldb file being created
and the script not to work at all.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13759

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andreas Schneider

samba_dnsupdate: make rodc_dns_update() more robust against timing problems

2019-02-14T01:18:29+00:00

Without this we had an interesting race!

The messaging_dgm code caches connected datagram sockets based on the
destination pid for 1 second.

The fact that samba_dnsupdate constantly recreates its messaging
context (and the underlying datagram socket) means that we the winbindd
messaging context may get a stale connection. As a result sending any
message from winbindd back to samba_dnsupdate will result in
ECONNREFUSED.

That means the IRPC response from winbindd never reaches
samba_dnsupdate, which will then hit a timeout.

In turn samba_dnsupdate on the RODC times out.

This was a workaround for the problem, by having just one global
IRPC handle and thus just one messaging_dgm context.
The actual problem is solved a few commits before
("messages_dgm: Properly handle receiver re-initialization").
But we keep this as an performance optimization, which hopefully
means that the overall samba_dnsupdate is less likely to
timeout after the hardcoded 20 seconds.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

samba_dnsupdate: make it clear that opts.use_file is active and we're not using nsupdate

2019-02-14T01:18:28+00:00

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett

s4/scripting/bin: open unicode files with utf8 encoding and write unicode string

2019-02-08T05:34:47+00:00

In files like `libcli/util/werror_err_table.txt` and `libcli/util/ntstatus_err_table.txt`,
there were unicode quote symbols at line 6:

    ...(“this documentation”)...

In `libcli/util/wscript_build`, it will run `gen_werror.py` and `gen_ntstatus.py`
to `open` above files, read content from them and write to other files.

When encoding not specified, `open` in both python 2/3 will guess encoding from locale.

When locale is not set, it defaults to POSIX or C, and then python will use
encoding `ANSI_X3.4-1968`.

So, on a system locale is not set, `make` will fail with encoding error
for both python 2 and 3:

    File "/home/ubuntu/samba/source4/scripting/bin/gen_werror.py", line 139, in main
        errors = parseErrorDescriptions(input_file, True, transformErrorName)
      File "/home/ubuntu/samba/source4/scripting/bin/gen_error_common.py", line 52, in parseErrorDescriptions
        for line in file_contents:
      File "/usr/lib/python3.5/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 318: ordinal not in range(128)

In this case, we have to use `io.open` with `encoding='utf8'`.
However, then we got unicode strs and try to write them with other strs
into new file, which means the new file must also open with utf-8 and
all other strs have to be unicode, too.

Instead of prefix `u` to all strs, a more easier/elegant way is to enable
unicode literals for the python scripts, which we normally didn't do in samba.

Since both `gen_werror.py` and `gen_ntstatus.py` are bin scripts and no
other modules import them, it should be ok for this case.

Signed-off-by: Joe Guo 

Autobuild-User(master): Douglas Bagnall 
Autobuild-Date(master): Fri Feb  8 06:34:47 CET 2019 on sn-devel-144