samba.git/source4/torture/drs/python, branch master

s4:torture: Retry DsExecuteKCC on NT_STATUS_DS_BUSY

2026-04-23T07:55:04+00:00

The KCC service runs a periodic samba_kcc child process (every 300s,
first at 15s after startup) with a 40 second timeout. If a test calls
DsExecuteKCC while the periodic child is running, kccsrv returns
NT_STATUS_DS_BUSY which propagates as EPT_NT_CANT_PERFORM_OP to the
client, causing flaky test failures.

UNEXPECTED(error): samba4.drs.samba_tool_drs_showrepl.python(schema_pair_dc).samba_tool_drs_showrepl.SambaToolDrsShowReplTests.test_samba_tool_showrepl(schema_pair_dc:local)
REASON: Exception: Exception: Traceback (most recent call last):
  File "/builds/samba-testbase/samba-def-build/source4/torture/drs/python/samba_tool_drs_showrepl.py", line 57, in test_samba_tool_showrepl
    kcc_out = self.check_output("samba-tool drs kcc %s %s" % (self.dc1,
  File "/builds/samba-testbase/samba-def-build/bin/python/samba/tests/__init__.py", line 593, in check_output
    raise BlackboxProcessError(retcode, line, stdoutdata, stderrdata)
samba.tests.BlackboxProcessError: Command 'python3 bin/samba-tool drs kcc liveupgrade1dc -USCHEMADOMAIN/Administrator%locDCpass1'; shell True; exit status 255;
stdout: ''; stderr: 'ERROR(runtime): DsExecuteKCC failed - (3221356597, 'The operation cannot be performed.')

3221356597 => 0xc0020035 (EPT_NT_CANT_PERFORM_OP)

Signed-off-by: Andreas Schneider 
Reviewed-by: Douglas Bagnall 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Thu Apr 23 07:55:04 UTC 2026 on atb-devel-224

pytest:repl_rodc: avoid using dsdb_dn.get_bytes

2025-08-07T23:28:33+00:00

Nobody else uses it, so let's just use .binary.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Gary Lockyer

s4:pytest:repl_rodc: use BinaryDn not dsdb_dn

2025-08-07T23:28:33+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Gary Lockyer

s4:torture:drs: Pass through unused parameters

2025-05-26T02:41:37+00:00

Signed-off-by: Jennifer Sutton 
Reviewed-by: Douglas Bagnall

s4: s/the the\b/the/ in miscellaneous comments

2024-11-06T10:57:35+00:00

Signed-off-by: Douglas Bagnall 
Reviewed-by: Volker Lendecke

s4:drs:test:getncchanges skips some tests with reserved_usn = 0

2024-08-28T04:24:39+00:00

These tests are not affected by the reserved_usn change, so there is
no need to run them twice.

The test_repl_get_tgt_multivalued_links fails with or without
reserved_usn set to zero, but it fails differently in either case.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15701

Signed-off-by: Douglas Bagnall 
Reviewed-by: Jennifer Sutton

s4:drs:test:getncchanges: remove timeout failure

2024-08-28T04:24:39+00:00

We don't need a timeout failure any more, since replication should
always work. Leaving the timeout in might sometimes cause a flapping
test if replication is being slow for some reason.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15701

Signed-off-by: Douglas Bagnall 
Reviewed-by: Jennifer Sutton

s4:drs:tests: repeat getncchanges test with zero reserved_usn

2024-08-28T04:24:39+00:00

This emulates the behaviour of Azure AD.

As this is quite slow we will later reduce the test load in this case,
but for now we want to run all the getncchanges tests this way.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15701

Signed-off-by: Douglas Bagnall 
Reviewed-by: Jennifer Sutton

s4:drs:tests: add hook for changing highwatermark

2024-08-28T04:24:39+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15701

Signed-off-by: Douglas Bagnall 
Reviewed-by: Jennifer Sutton

s4:drs:test:getncchanges: add a timeout failure

2024-08-28T04:24:39+00:00

In the next commit we are going to add tests in which the client
modifies the highwatermark in a way that resets replication (on Samba
only). After that we'll fix it.

If we leave the test in an eternal loop, the commit history will not
be bisectable, so we are temporarily going to turn long waits into
failures.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15701

Signed-off-by: Douglas Bagnall 
Reviewed-by: Jennifer Sutton