samba.git/source4/torture/ldap, branch master

libcli: Move "struct cldap_netlogon" definition to torture

2024-11-11T14:03:04+00:00

This structure is only used in torture/ldap/netlogon.c now for
historic reasons. Replacing it with something else would be the right
thing to do...

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

torture4: Replace direct netlogon ping calls with netlogon_pings()

2024-11-11T14:03:04+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

torture4: Add ldap.netlogon-ping test

2024-11-11T14:03:04+00:00

This will supersede the direct cldap based netlogon tests

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

torture4: Use netlogon_pings_send/recv in bench-cldap

2024-11-11T14:03:04+00:00

This slightly changes behaviour: It uses separate client sockets per
ping instead of just one, but it allows to compare CLDAP with LDAP and
LDAPS (spoiler: LDAPS is *much* slower...)

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

param: Remove parameter "cldap port"

2024-11-11T14:03:03+00:00

This was not used consistently across all of our code base, and I
don't see a reason why this should ever not be port 389.

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

cldap: Make cldap_netlogon.out.netlogon a pointer

2024-11-11T14:03:03+00:00

struct netlogon_samlogon_response has subpointers, this patch enables
a proper talloc hierarchy.

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

lib: Fix trailing whitespace

2024-11-11T14:03:03+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

torture4: Simplifiy [tcp|udp]_ldap_netlogon()

2024-11-11T14:03:03+00:00

Both callers set "map_response=true", so we don't need that flag here.

Signed-off-by: Volker Lendecke 
Reviewed-by: Stefan Metzmacher

s4:torture: Initialize struct cldap_netlogon

2024-07-18T13:48:03+00:00

"Error: UNINIT (CWE-457):
samba-4.20.0rc2/source4/torture/ldap/cldapbench.c:40: var_decl: Declaring variable ""io"" without initializer.
samba-4.20.0rc2/source4/torture/ldap/cldapbench.c:45: uninit_use_in_call: Using uninitialized value ""io.in.map_response"" when calling ""cldap_netlogon_recv"".
   43|   	TALLOC_CTX *tmp_ctx = talloc_new(NULL);
   44|   	io.in.version = 6;
   45|-> 	status = cldap_netlogon_recv(req, tmp_ctx, &io);
   46|   	talloc_free(req);
   47|   	if (NT_STATUS_IS_OK(status)) {"

Signed-off-by: Andreas Schneider 
Reviewed-by: Alexander Bokovoy 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Thu Jul 18 13:48:03 UTC 2024 on atb-devel-224

s4:torture: Remove trailing spaces from cldapbench.c

2024-07-18T12:47:30+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Alexander Bokovoy