samba.git/source4/torture/libnetapi, branch master

s4:torture:libnetapi: group fix cast-align warnings

2026-03-20T13:27:34+00:00

Adds code to check that buffer is aligned correctly for the expected types.
Then suppresses the cast-align warnings with discard_align_p

Signed-off-by: Gary Lockyer 
Reviewed-by: Volker Lendecke

s4:torture:libnetapi: user fix cast-align warnings

2026-03-20T13:27:34+00:00

Use talloc_get_type_abort to suppress cats-align warnings.
As buffer is allocated via talloc it will be correctly aligned.

Signed-off-by: Gary Lockyer 
Reviewed-by: Volker Lendecke

netapi: Pass net's cmdline credentials to libnetapi_net_init()

2023-09-11T02:42:41+00:00

Avoid unnecessary credentials allocation and initialization by passing the
net's cmdline creds to libnetapi_net_init() directly.

Fixes the problem of running cli_credentials_guess() (which runs password
callbacks) twice, one for the net's cmdline creds and a second time for the
creds initialized in libnetapi_net_init(), just to override them immediately
after.

Example:

$ export PASSWD_FD=0
$ ./bin/net offlinejoin composeodj <...>
foo
bar

Password is read from STDIN twice.

Signed-off-by: Samuel Cabrero 
Reviewed-by: Andrew Bartlett

netapi: Pass loadparm_context to libnetapi_net_init()

2023-09-11T02:42:41+00:00

The net's tool cmdline lp_ctx can be reused, no need to init a new one except
for external library users.

Signed-off-by: Samuel Cabrero 
Reviewed-by: Andrew Bartlett

s4:torture:libnetapi: Fix code spelling

2023-08-14T21:45:30+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

torture: Fix build on freebsd, missing deps on cmdline

2021-06-22T02:05:17+00:00

Missing dependency causes build failure on freebsd.

[2928/3944] Compiling source4/torture/util_smb.c
In file included from ../../source4/torture/util_smb.c:22:
../../lib/cmdline/cmdline.h:22:10: fatal error: 'popt.h' file not found
         ^~~~~~~~
1 error generated.

Signed-off-by: Amitay Isaacs 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Tue Jun 22 02:05:17 UTC 2021 on sn-devel-184

s4:torture: Migrate smbtorture to new cmdline option parser

2021-06-16T00:34:38+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett

lib: Remove init_names()

2021-03-16T17:09:32+00:00

is_myname() looks at lp_* directly, nmbd maintains its own list: We don't
need the baroque loadparm handler anymore.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

lib/util: remove extra safe_string.h file

2020-08-28T02:18:40+00:00

lib/util/safe_string.h is similar to source3/include/safe_string.h, but
the former has fewer checks. It is missing bcopy, strcasecmp, and
strncasecmp.

Add the missing elements to lib/util/safe_string.h remove the other
safe_string.h which is in the source3-specific path. To accomodate
existing uses of str(n?)casecmp, add #undef lines to source files where
they are used.

Signed-off-by: Matthew DeVore 
Reviewed-by: David Mulder 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Aug 28 02:18:40 UTC 2020 on sn-devel-184

s4:torture: Initialize pointers in libnetapi user test

2018-11-22T21:13:26+00:00

Found by Undefined Sanitizer.

Signed-off-by: Andreas Schneider 
Reviewed-by: Gary Lockyer