samba.git/source4, branch ldb-1.2.3

s4:samba: Fix default to be running samba as a deamon

2017-12-20T23:55:29+00:00

Commit 8736013dc42c5755b75bbb2e843a290bcd545909 got the (confusing) sense of opt_fork
wrong.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13129

Signed-off-by: Andrew Bartlett 
Reviewed-by: Garming Sam 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Tue Dec 19 11:24:29 CET 2017 on sn-devel-144

(cherry picked from commit 0806ff7dfd3f982226e4cd9b923a0e570b765f0c)

Autobuild-User(v4-7-test): Karolin Seeger 
Autobuild-Date(v4-7-test): Thu Dec 21 00:55:29 CET 2017 on sn-devel-144

s4/torture: fruit: in test_adouble_conversion() also check stream list and AFPINFO_STREAM

2017-12-05T09:34:26+00:00

This reveals that the conversion doesn't work properly with
fruit:metadata=stream.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13155

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 
(cherry picked from commit 7b00b558761b6564928289efcf835e9b9cc86a89)

s4/torture: fruit: remove use of localdir from test_adouble_conversion test

2017-12-05T09:34:26+00:00

The previous use of localdir and torture_setup_local_file() was
motivated by the fact that by default vfs_fruit rejects access to files
with a "._" prefix.

Since a previous commit allowed SMB access to ._ files, rewrite the
test_adouble_conversion() test to create the ._ AppleDouble file over
SMB.

This also renders torture_setup_local_file() obsolete.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13155

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 
(cherry picked from commit ebbffd80862d7d7b025eca219bc0c8f818585ac9)

selftest: add "fruit:veto_appledouble = no" to fruit shares

2017-12-05T09:34:26+00:00

This is needed for a subsequent commit that modifies an existing test to
write a ._ file over SMB instead of using the ugly local creation hack.

SMB acces of ._ files requires "fruit:veto_appledouble = no", so let's
set it.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13155

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 
(cherry picked from commit 3f9b45a410384904d64bdd0d68ff2a5bc25bd3e9)

s4/torture: let write_stream() deal with stream=NULL

2017-12-05T09:34:26+00:00

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13155

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 
(cherry picked from commit ac880848a905a3840b69af2cb1d842d307401a07)

selftest: run AppleDouble sidecar-file conversion test runs against all fruit shares

2017-12-05T09:34:26+00:00

This needs for work in all possible fruit configs, so test it.

This currently fails with stream_depot, as we don't propely copy over
the resourcefork data from the ._ file to the stream.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13155

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 
(cherry picked from commit e28dd6a0ce753a880b2512eb62661411b20f763b)

s4/torture: use torture_assert_goto in a vfs.fruit test

2017-12-05T09:34:26+00:00

No change in behavior.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13155

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 
(cherry picked from commit 9af9c5c073d88b126aebd4a2d7a1a1971527fbf4)

s4/torture: rework stream names tests usage of local xattr call

2017-12-05T09:34:26+00:00

Previously this test, that tests for correct conversion of ':' in stream
names, only worked with streams_xattr with "fruit:metadata" set to
"netatalk".

In order to have test coverage for fruit shares with other configs,
split the test into two:

one test creates the stream over SMB and run against all shares, the
other one is the unmodified existing test and is only run against the
share with streams_xattr and fruit:metadata=netatalk.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13155

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 
(cherry picked from commit 75a3c0f3b1f843ba9a7838aa7a1c311fc262f8c7)

s4:samba: Allow samba daemon to run in foreground

2017-11-30T13:11:02+00:00

We are passing the no_process_group to become_daemon() that setsid() is
not called. In case we are double forking, we run in SysV daemon mode,
setsid() should be called!

See:
https://www.freedesktop.org/software/systemd/man/daemon.html

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13129

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett 

(cherry picked from commit 8736013dc42c5755b75bbb2e843a290bcd545909)

Autobuild-User(v4-7-test): Karolin Seeger 
Autobuild-Date(v4-7-test): Thu Nov 30 14:11:02 CET 2017 on sn-devel-144

s4:samba: Do not segfault if we run into issues

2017-11-30T08:47:14+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett 
(cherry picked from commit bfafabfb942668328401a3c89fc55b50dc56c209)