samba.git/wscript, branch talloc-2.3.3

build: wscript. Fix the build on FreeBSD with the clang ld.lld-XX linker.

2021-05-14T01:50:25+00:00

FreeBSD is broken. It doesn't include 'extern char **environ'
in any shared library, but statically inside crt0.o.

If we're running on a FreeBSD with the GNU linker ld we
can get around this by explicitly telling the linker to
ignore 'environ' as an unresolved symbol in a shared library.

However, the clang linker ld.lld-XX is broken in that it
doesn't have that option.
First try to see if have '-Wl,--ignore-unresolved-symbol,environ'
and just use that if so.

If not, we have to use '-Wl,--allow-shlib-undefined' instead
and remove all instances of '-Wl,-no-undefined'.

Signed-off-by: Jeremy Allison 
Reviewed-by: Martin Schwenke 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri May 14 01:50:25 UTC 2021 on sn-devel-184

build: Use bison at build time rather than lexyacc.sh to build the embedded heimdal

2021-04-28T03:43:34+00:00

Because the filenames are changed to the *.tab.{h,c} format
a transitional header is added.

While the built compilers differ, the output of the compilers
and the resulting .o files have been verified not to have changed
on Ubuntu 20.04.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

build: Only add -Wl,--as-needed when supported

2021-04-07T02:17:34+00:00

If -Wl,--as-needed is added to EXTRA_LDFLAGS (via ADD_LDFLAGS, as per
commit 996560191ac6bd603901dcd6c0de5d239e019ef4) then on some
platforms (at least CentOS 8 and Fedora 33), any indirect/recursive
dependencies (i.e. private libraries) are added to both the
binary (reqid_test in the CTDB case) and to samba-util.so.  However,
only samba-util.so has rpath set to find private libraries.

When ld.so tries to resolve these dependencies for the binary it
fails. This may be a bug on those platforms, but it occurs reliably
and our users will also hit the bug.  For binaries that have other
private library dependencies (e.g. bundled talloc) rpath will contain
the private library directory so the duplicate private library
dependencies are then found... that is, when it works, it works by
accident!

For some reason (deep in waf or wafsamba) if -Wl,--as-needed is added to
LINKFLAGS (as is done in conf.add_as_needed()) then it works: the direct
dependencies are only added to samba-util.so and the same depenencies
(indirect dependencies for binaries) are not added incorrectly to the
binaries.

So, without changing 1/2 of waf/wafsamba the simplest fix is to revert
to adding -Wl,--as-needed to LINKFLAGS, which was the case before
commit 996560191ac6bd603901dcd6c0de5d239e019ef4.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14288

Signed-off-by: Amitay Isaacs 
Signed-off-by: Martin Schwenke 
Reviewed-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

build: Notice if flex is missing at configure time

2021-03-29T02:12:23+00:00

This may also fix the coverage build by ensuring --noline
is always specified to flex.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14586

Signed-off-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Mon Mar 29 02:12:23 UTC 2021 on sn-devel-184

build: Consolidate --with-ntvfs-fileserver into --enable-selftest when building the AD DC

2021-03-26T03:04:39+00:00

This removes from our configure help a feature which we retain only
to support our selftest system.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Jeremy Allison

wscript: use --as-needed only if tested successfully

2021-03-03T11:31:34+00:00

Some OSes like Solaris based OmiOS don't support this.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14288

Signed-off-by: Bjoern Jacke 
Reviewed-by: Andrew Bartlett

Compile .l files (flex) with the waf rule at runtime

2020-08-07T03:23:44+00:00

Other parts of Samba already compile these directly.

This makes these files compile with modern compiler warnings.

The primary difference (other than being built with a newer
flex) is the loss of the #include "config.h" but
this is not used in the other .l files elsewehre and does not
seem to matter on modern systems.

The generated output from compile_et asn1_compile has not changed
(so I think the hx509 case is safe).

The mdssvc case just has changed file locations and line numbers.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall

build: Put the note from the bottom of the old BUILD_SYSTEMS.txt somewhere useful

2020-06-12T22:11:43+00:00

This statement on how we handle --with options is best placed near where
the options are set, so developers see it when trying to choose the
correct thing to do.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Jeremy Allison

waf: Use waf function to add for -Wl,--as-needed

2019-09-25T16:56:39+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Matthias Dieter Wallnöfer 
Reviewed-by: Alexander Bokovoy 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Wed Sep 25 16:56:40 UTC 2019 on sn-devel-184

wscript: avoid inefficient string concatenations

2019-09-24T12:22:45+00:00

Signed-off-by: Bjoern Jacke 
Reviewed-by: Matthias Dieter Wallnöfer