python:tests: Fix assertEqual placement in test_device_group_restrictions

The assertEqual calls checking the exception attributes were incorrectly
indented inside the 'with self.assertRaises()' block. When the expected
NTSTATUSError is raised by verify_access(), execution exits the block
immediately, so those lines were never reached.
When the exception is not raised (e.g. with MIT KRB5 1.22 where a spurious FAST
error was fixed), execution falls through to the assertEqual inside the block,
causing AttributeError because error.exception is only available after the
'with' block exits.

The exception returned is NT_STATUS_UNSUCCESSFUL with Heimdal.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>

1 files changed, 4 insertions, 5 deletions

diff --git a/python/samba/tests/blackbox/claims.py b/python/samba/tests/blackbox/claims.py
index da616e3b726..2e53ae80241 100755
--- a/python/samba/tests/blackbox/claims.py
+++ b/python/samba/tests/blackbox/claims.py
@@ -92,11 +92,10 @@ class ClaimsSupportTests(BlackboxTestCase):
                 device_password=device_password,
             )
 
-            self.assertEqual(error.exception.args[0], NT_STATUS_LOGON_FAILURE)
-            self.assertEqual(
-                error.exception.args[1],
-                "The attempted logon is invalid. This is either due to a "
-                "bad username or authentication information.")
+        self.assertEqual(error.exception.args[0], NT_STATUS_UNSUCCESSFUL)
+        self.assertIn(
+            "The requested operation was unsuccessful.",
+            error.exception.args[1])
 
         self.check_run("group addmembers allowed-devices claims-device")