summaryrefslogtreecommitdiff
path: root/ctdb/server
AgeCommit message (Collapse)AuthorFilesLines
2025-08-07ctdb: Fix a stuck cluster lock holder after a delayed leader bcastVolker Lendecke1-0/+1
If a delayed broadcast by a previous cluster lock holder arrives, the new legitimate leader will accept this without questioning in leader_handler(). Without this patch rec->leader will never be overwritten, and because rec->pnn != rec->leader we'll also never send out fresh leader broadcasts. And because we hold the cluster lock, nobody else can step up. Fix this in the next round of leader broadcast timeout. Bug: https://bugzilla.samba.org/show_bug.cgi?id=15892 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Thu Aug 7 02:59:20 UTC 2025 on atb-devel-224
2025-07-23ctdb-server: Load optional tunables.d/ directoryMartin Schwenke1-9/+25
Change the variable name to "path" so it makes sense to reuse it for the directory. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Wed Jul 23 00:02:47 UTC 2025 on atb-devel-224
2025-07-22ctdb-server: Whitespace fixesMartin Schwenke1-3/+3
Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2025-07-22ctdb-common: Require separate initialisation of tunable defaultsMartin Schwenke1-0/+2
Dropping this from ctdb_tunable_load_file() allows that function to be called multiple times for different files. The caller sets the defaults. In the test script, factor out the handling of a single tunables file in a similar way. Ignoring missing/unreadable files is OK because this function will only be called for test successes (hence "ok" in the name). There will never be existing, unreadable files. The code being tested ignores missing files, so do that here too. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2025-05-29ctdb-daemon: Modernise some DEBUGsMartin Schwenke1-3/+3
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15858 Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Thu May 29 10:57:35 UTC 2025 on atb-devel-224
2025-05-29ctdb-daemon: Add configuration option shutdown extra timeoutMartin Schwenke1-0/+23
See documentation change for details. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15858 Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2025-05-29ctdb-daemon: Run "startipreallocate" event in SHUTDOWN runstateMartin Schwenke1-2/+3
Even though all nodes may be shutting down there is still a very small window for a race when multiple nodes are shut down. For simplicity, assume 2 nodes. Assume the shutdowns of nodes are staggered, which is usual because they're usually initiated by a loop (e.g. onnode -p all ctdb shutdown). Although commands can continue in parallel, some commands are started later than others. Consider this sequence: 1. Node 0 reaches ctdb_shutdown_takeover() in ctdb_shutdown_sequence() and a takeover run starts 2. Node 1 has not yet set its runlevel to SHUTDOWN in ctdb_shutdown_sequence() 3. The leader node asks node 1 which IPs it can host 4. Node 1 replies "all of them" 5. Node 1 now sets its runlevel to SHUTDOWN in ctdb_shutdown_sequence() 6. The leader node continues with the takeover run, first asking all nodes to run "startipreallocate" 7. Node 0 runs "startipreallocate", so its NFS server starts grace 8. Node 1 does not run "startipreallocate" because it is not in RUNNING runstate, so its NFS server does not start grace 9. The leader node continues with the takeover run, first asking all nodes to run "releaseip" for IPs they can no longer hold 10. Node 0 releases all IPs, since it is SHUTDOWN runstate (so can't host IPs) 11. As part of this, the NFS server on node 0 releases locks held against IPs it is releasing 12. A client connected to node 1, where the NFS server is not in grace, takes ("steals") one of those locks This client is then permitted to reclaim the lock when nodes are restarted. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15858 Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2025-05-29ctdb-daemon: Add configuration option shutdown failover timeoutMartin Schwenke1-4/+3
Allows the timeout for failover during shutdown to be modified. Defaults to 10s. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15858 Signed-off-by: Martin Schwenke <mschwenke@ddn.com> SQ Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2025-05-29ctdb-daemon: Add failover on shutdownMartin Schwenke1-0/+201
Without this, NFS servers on other nodes will not go into grace before this node releases locks. This should also support improved behaviour for SMB durable file handles. The timeout is currently a constant 10s. However, it will subsequently be switched to an option. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15858 Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2025-05-29ctdb-daemon: Avoid aborting during early shutdownMartin Schwenke1-0/+18
An early shutdown can put ctdbd into SHUTDOWN runstate before ctdbd has completed all early initialisation. Some of the start-time transitions then attempt to set the runstate to FIRST_RECOVERY or RUNNING, which would make the runstate go backwards, so ctdbd aborts. Upcoming changes cause ctdbd shutdown to take longer, so the problem will become more likely. With those changes, this can be unreliably (50% of the time?) triggered by: ctdb/tests/INTEGRATION/simple/cluster.091.version_check.sh since it does an early shutdown due to a version mismatch. Avoid this by noticing when the runstate is SHUTDOWN and refusing to continue with subsequent early initialisation steps, which aren't needed when shutting down. Earlier runstate transitions do not seems likely to cause an abort during early shutdown. The following: ./tests/local_daemons.sh foo start 0; ./tests/local_daemons.sh foo stop 0 sees ctdbd already into FIRST_RECOVERY before the shutdown is processed. The change to ctdb_run_startup() probably isn't strictly necessary. There will be no abort in this case. ctdb_shutdown_sequence() will always run the "shutdown" event and then stop the event daemon, so it doesn't seem possible that services could be left running. However, we might as well avoid running the "startup" event when shutting down, even if only to avoid confusing logs. Ultimately, it seems like some redesign would be needed to avoid this in a more predictable manner, rather than responding when an early initialisation step inconveniently completes during shutdown. For example, hanging a lot of the start-time event handling off a common talloc context, could allow it to be cancelled with a single TALLOC_FREE(). However, a change like that would involve a lot of analysis to ensure that the talloc hierarchy is correct and there is no change of free'd pointers being dereferenced. So, we're probably better off just keeping this issue in mind during a broader redesign. This workaround appears to be sufficient. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15858 Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2025-01-02remove usage of bzeroMichael Tokarev2-5/+5
bzero() function has been deprecated for a long time. In samba it is replaced with memset(). But samba also provides common memory-zeroing macros, like ZERO_STRUCT(). In all places where bzero() is used, it actually meant to zero a structure or an array. So replace these bzero() calls with ZERO_STRUCT() or ZERO_ARRAY() as appropriate, and remove bzero() replacement and testing entirely. While at it, also stop checking for presence of memset() - this function is standard for a very long time, and the only conditional where HAVE_MEMSET were used, was to provide replacement for bzero() - in all other places memset() is used unconditionally. Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
2024-11-06ctdb-server: Use ctdb_connection_same() to simplifyMartin Schwenke1-2/+1
Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jerry Heyman <jheyman@ddn.com>
2024-11-06ctdb: Don't leak a pointer on talloc_realloc failureVolker Lendecke1-5/+7
We should not directly overwrite the pointer we are realloc'ing Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net>
2024-11-06ctdb: Save a few lines with talloc_zero()Volker Lendecke1-4/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net>
2024-11-06ctdb-server: Remove duplicate logicMartin Schwenke1-12/+1
Initialise the pointer to NULL and fall through to let talloc_realloc() do the allocation. talloc_realloc() does the right thing with a NULL pointer... Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jerry Heyman <jheyman@ddn.com>
2024-11-06ctdb-server: Handle pre-existing connection firstMartin Schwenke1-7/+6
This is cheap when tcparray is NULL and let's the code that now follows be simplified. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jerry Heyman <jheyman@ddn.com>
2024-11-06ctdb-server: Drop an unnecessary variableMartin Schwenke1-4/+1
Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jerry Heyman <jheyman@ddn.com>
2024-11-06ctdb-server: Drop a log message to DEBUG levelMartin Schwenke1-1/+1
This is harmless, so it doesn't generally need to be logged. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jerry Heyman <jheyman@ddn.com>
2024-11-06ctdb-server: Clean up connection tracking functionsMartin Schwenke1-43/+65
Apply README.Coding, modernise logging, pre-render connection as a string for logging, switch terminology from "tickle" to "connection", tidy up comments. No changes in functionality. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jerry Heyman <jheyman@ddn.com>
2024-10-08ctdb-server: Use find_public_ip_vnn() in a couple of extra placesMartin Schwenke1-56/+51
Reorder code to use early returns, modernise debug. Best reviewed with "git show -w". Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Anoop C S <anoopcs@samba.org> Autobuild-User(master): Anoop C S <anoopcs@samba.org> Autobuild-Date(master): Tue Oct 8 06:42:04 UTC 2024 on atb-devel-224
2024-10-08ctdb-server: Clean up find_public_ip_vnn()Martin Schwenke1-5/+5
Fix the comment (NULL versus -1), apply some README.Coding. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-10-08ctdb-daemon: Ensure CTDB_BASE is set, don't fetch itMartin Schwenke1-5/+3
Uses of CTDB_BASE in the subsequent code are now handled by the path module, so there is no point getting the value of CTDB_BASE. Instead, check that the attempt to set it worked, noting that: [...] if overwrite is zero, then the value of name is not changed (and setenv() returns a success status). Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-10-08ctdb-daemon: Use path_etcdir_append() to construct some pathsMartin Schwenke2-13/+5
No need to use CTDB_BASE directly. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-10-08ctdb-daemon: Replace remaining uses of CTDB_NO_MEMORY() in this fileMartin Schwenke1-4/+18
Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-10-08ctdb-daemon: Clean up error handling and debugMartin Schwenke2-3/+12
Add some missing error handling and error messages. Remove a use of CTDB_NO_MEMORY(), which then renders the caller's use of ctdb_errstr() pointless, so remove that too. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-10-08ctdb-daemon: Use ctdb_vnn_address_string() in old-style debuggingMartin Schwenke1-91/+88
Modernise the debug macros along the way. These are done separately because they will require a little more patience to review. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-10-08ctdb-daemon: Add ctdb_vnn_address_string() and use in trivial placesMartin Schwenke1-12/+18
Define a static function to return the string. This clearly doesn't need a ctdb_ prefix, but it matches ctdb_vnn_iface_string(), so doesn't look out of place. Use it in the places where review is trivial. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-10-08ctdb-daemon: Store public address string in VNNMartin Schwenke1-0/+9
These are currently converted to strings constantly in log messages and other places. This clutters the code and probably has a minor performance impact. Add a new string field to the VNN structure. Populate it when a public address is added and the VNN structure is allocated. This is consistent with how node addresses are handled. Don't use it yet, or this commit becomes huge. A short-term goal is that each VNN public address will be converted to a string only once. A longer-term goal is to reduce use of ctdb_addr_to_str(). Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-10-08ctdb-daemon: Fix a commentMartin Schwenke1-1/+1
The word "no" was accidentally dropped in commit 1e47a1b3f6ab1e2ad9d86dfb28c3e086c99a97e5. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-10-08ctdb-daemon: Drop unused argumentsMartin Schwenke2-7/+6
Unused since commit a10545ab6bd8a1b9ca87b0fdba8381cb8af0e284. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-10-08ctdb-daemon: Improve error handling when releasing all IPsMartin Schwenke1-12/+30
Currently, event failures are completely ignored in favour of checking if the IP is on an interface. This misses the case where event scripts up to and including 10.interface succeed, but something later fails. When that occurs, count is incremented, so the failure is counted as a success in the summary that is logged. Fail when releaseip fails even though 10.interface succeeded in releasing the IP. This may result in the IP address coming back, but that's a different problem. Underlying this is a design question about when releaseip is successful. Should releaseip be a distinct operation, with subsequent reconfigurations considered separately? Update logging to clearly identify each of the 3 possible errors. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-10-07ctdb-server: Optimise local IP verificationMartin Schwenke1-1/+25
It is more efficient calling ctdb_sys_local_ip_check() inside a loop compared to calling ctdb_sys_have_ip(). There is a chance that this is premature optimisation... but it sure is easy. Fall back to checking with bind(). I think these checks really exist because of the weirdness fixed by commit 4b4e4d8870475d994fe42a7b2c57dc69842d91f6. However, we might as well do what we can. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: John Mulligan <jmulligan@redhat.com> Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-10-07ctdb-server: Add some local variablesMartin Schwenke1-8/+9
Improve readability by not repeating the complex expression now assigned to addr. ctdb_sys_have_ip() is called in both arms of the if/else, so call it once when declaring the new variable. Modernise debug macros while touching lines. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: John Mulligan <jmulligan@redhat.com> Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-09-22ctdb: Use str_list_add_printf() in lock_helper_args()Volker Lendecke1-59/+33
Saves lines, str_list_add_printf takes care of NULL checks Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Sun Sep 22 10:44:59 UTC 2024 on atb-devel-224
2024-09-22ctdb: Change the ctdb_vfork_exec prototype to const char*const*Volker Lendecke1-3/+5
I could not find out how to cast a char ** to const char ** without warning. This transfers fine to the execv call as well. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net>
2024-09-20ctdb: Use str_list_add_printf() in debug_locks_args()Volker Lendecke1-42/+17
Saves lines, str_list_add_printf takes care of NULL checks Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Noel Power <noel.power@suse.com>
2024-09-20ctdb: Make ctdb_lock_timeout_handler() easier to understandVolker Lendecke1-18/+21
Don't hide the real action inside an if-branch Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Noel Power <noel.power@suse.com>
2024-08-27ctdb: Add a NULL check to convert_node_map_to_list()Volker Lendecke1-0/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jennifer Sutton <jsutton@samba.org>
2024-08-20ctdb-daemon: Remove a use of ctdb_errstr()Martin Schwenke1-1/+1
Code to setup the transport is about to be cleaned up, including removing uses of ctdb_set_error(), so avoid logging a NULL pointer or some other old error. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Volker Lendecke <vl@samba.org>
2024-08-06ctdb-conf: add boolean arg for verbosity when loading configJohn Mulligan1-1/+1
In a future commit we will add support for loading the config file from the `ctdb` command line tool. Prior to this change the config file load func always called D_NOTICE that causes the command to emit new text and thus break all the tests that rely on the specific test output (not to mention something users could notice). This change plumbs a new `verbose` argument into some of the config file loading functions. Generally, all existing functions will have verbose set to true to match the existing behavior. Future callers of this function can set it to false in order to avoid emitting the extra text. Signed-off-by: John Mulligan <jmulligan@redhat.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
2024-08-06ctdb-server: rename ctdb_load_nodes_file to ctdb_load_nodesJohn Mulligan4-6/+6
Rename ctdb_load_nodes_file to ctdb_load_nodes as it can now load nodes from more than a regular file. Signed-off-by: John Mulligan <jmulligan@redhat.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
2024-08-06ctdb-server: rename nodes_file field to nodes_sourceJohn Mulligan3-6/+6
Rename the `struct ctdb_context` field nodes_file to nodes_source to better match that the field may indicate something other than a true file. Signed-off-by: John Mulligan <jmulligan@redhat.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
2024-08-06ctdb-server: use the new "nodes list" configuration optionJohn Mulligan1-1/+2
Use the new "nodes list" configuration option. Executing the given path if the path is prefixed by a `!`. The use case is to decouple the nodes file from the shared storage, especially in the case where the shared storage is provided by a vfs module. For an example, imagine a script that runs `curl` on a URL for a highly-available web server where the URL provides the content of the nodes file. Signed-off-by: John Mulligan <jmulligan@redhat.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
2024-07-23ctdb-daemon: Use ctdb_parse_node_address() in ctdbdMartin Schwenke1-1/+5
While here, fix a trivial memory leak (ctdbd will exit anyway if this function fails). Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Anoop C S <anoopcs@samba.org> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Tue Jul 23 12:39:18 UTC 2024 on atb-devel-224
2024-07-23ctdb-daemon: Use ctdb_read_nodes() in ctdbdMartin Schwenke2-12/+42
ctdb_control_getnodesfile() calls ctdb_read_nodes(), which returns a struct ctdb_node_map rather than the old version, so update associated marshalling. While here modernise a debug message and wrap the function arguments. For ctdb_load_nodes_file() to use ctdb_read_nodes(), tweak convert_node_map_to_list() to also use the modern node map structure. Remove unused copy of ctdb_read_nodes_file(). Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-06-28ctdb-conf: Rename config loading to not be daemon-specificMartin Schwenke1-2/+2
We might end up using it elsewhere. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Guenther Deschner <gd@samba.org> Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-06-28ctdb-conf: Move all conf files to new conf/ subdirectoryMartin Schwenke8-362/+5
Leave common/conf.[ch] where they are to make this commit comprehensible. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Guenther Deschner <gd@samba.org> Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-04-17ctdb: Modernize a few DEBUGsVolker Lendecke1-13/+23
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Martin Schwenke <mschwenke@ddn.com> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Wed Apr 17 00:54:55 UTC 2024 on atb-devel-224
2024-04-16lib: Give lib/util/util_file.c its own header fileVolker Lendecke1-0/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Martin Schwenke <mschwenke@ddn.com>
2024-03-22lib: Remove timeval_until()Volker Lendecke1-2/+2
We have the same function in tevent, no need to duplicate code. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
generated by cgit v1.2.3 (git 2.25.1) at 2026-06-26 08:21:13 +0000