summaryrefslogtreecommitdiff
path: root/python
AgeCommit message (Collapse)AuthorFilesLines
2024-09-26tests: Check that posix extensions return the file typeVolker Lendecke1-1/+13
We'll need to check more, but this is a start Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
2024-09-26idl: Rename smb3_posix_cc_info.posix_perms to posix_modeVolker Lendecke1-2/+2
We'll stash the file type in there soon Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
2024-09-24samba-tool: Fix for inability to delete GPOs containing GPWL policiesKacper Boström1-2/+2
GPOs containing GPWL (Wireless/Wired Protocol Extension) policies could not be deleted with samba-tool as those policies were stored as subentries of the GPO and only the main root was deleted. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15387 RN: Fix for inability to delete GPOs containing GPWL policies using samba-tool Signed-off-by: Kacper Boström <kacper@kacper.se> Reviewed-by: David Mulder <dmulder@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Tue Sep 24 17:11:53 UTC 2024 on atb-devel-224
2024-09-10tests: Improve the error message for bad format charsVolker Lendecke1-1/+1
Print the faulty character for easier finding it. I did not find out how to split the format string into two lines such that self.fail would properly print the whole thing in its exception, so we have a long line here. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2024-09-10netcmd: user: Fix typo in samba-tool error messageLyanis Souidi1-1/+1
Fix typo in "samba-tool user add" error message when adding a user with NIS features : the argument for the uid number is --uid-number and not --uidNumber. RN: Fix typo in samba-tool error message. Signed-off-by: Lyanis Souidi <lyanis.souidi@u-pec.fr> Reviewed-by: Jennifer Sutton <josutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2024-08-04python:tests: Remove unused variableJo Sutton1-1/+1
assertMatch() returns None, which isn’t very useful. Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2024-08-04python:provision: Do not suppress errors produced setting up BIND databaseJo Sutton1-6/+6
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2024-08-04python:tests: Account for new user ‘joe’Jo Sutton1-1/+1
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2024-08-04python:netcmd: Explicitly delete samdb variablesJo Sutton1-2/+2
This makes our intent clear, and avoids accidental attempts to use these objects after they have been ‘disconnect()’ed. Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2024-08-04tests/krb5: Remove unneeded machine account creationJo Sutton1-10/+2
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2024-08-04tests/krb5: Remove unneeded parameter ‘samdb’Jo Sutton1-14/+9
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2024-08-04python:tests: Fix code spellingJo Sutton1-1/+1
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2024-08-04python:tests: Fix code spellingJo Sutton1-1/+1
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2024-07-25libcli:security: allow spaces after BAD:Douglas Bagnall1-5/+5
In AD_DS_Classes_Windows_Server_v1903.ldf from https://www.microsoft.com/en-us/download/details.aspx?id=23782, we see defaultSecurityDescriptor: O:BAG:BAD: (A;;RPWPCRCCDCLCLORCWOWDSDDTSW;;;DA)(A;;RPLCLORC;;;AU) BUG: https://bugzilla.samba.org/show_bug.cgi?id=15685 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org> Autobuild-Date(master): Thu Jul 25 06:27:27 UTC 2024 on atb-devel-224
2024-07-17python:tests: make test_export_keytab_nochange_update() more reliableStefan Metzmacher1-6/+36
net.export_keytab() includes the current timestamp into the resulting keytab. So we need to make sure the two compared exports actually run within the same second. And klist may also print the keytab filename... Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Jul 17 14:21:30 UTC 2024 on atb-devel-224
2024-07-17s3:passdb: don't clear the LM HASH without a password changeStefan Metzmacher1-1/+1
Updating things like the bad pwd count should not clear the stored LM HASH with 'lanman auth = no'. This allows testing with 'lanman auth = no' and 'lanman auth = yes'. BUG: https://bugzilla.samba.org/show_bug.cgi?id=9705 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2024-07-17python:tests: Fix spelling in to test_samba_dnsupdate_no_changePavel Filipenský1-2/+2
Signed-off-by: Pavel Filipenský <pfilipensky@samba.org> Reviewed-by: Reviewed-by: Martin Schwenke <martin@meltin.net>
2024-07-16python:tests: pass bytes.decode() instead of str(bytes) to ↵Stefan Metzmacher1-1/+2
assertMultiLineEqual() to get better failure output When not equal a diff of the two strings highlighting the differences will be included this way. This is a flapping test. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Tue Jul 16 07:40:41 UTC 2024 on atb-devel-224
2024-07-15python:tests: Use assertMultiLineEqual() to get better failure outputAndreas Schneider1-1/+2
When not equal a diff of the two strings highlighting the differences will be included this way. This is a flapping test. Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Andreas Schneider <asn@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon Jul 15 13:51:03 UTC 2024 on atb-devel-224
2024-07-12tests: Sockets should be shown as NFS reparse pointsVolker Lendecke1-0/+4
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2024-07-12tests: Factor out do_test_nfs_reparseVolker Lendecke1-5/+8
Will be used for sockets next Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2024-07-12tests: FIFOs should be shown as NFS reparse pointsVolker Lendecke1-0/+37
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2024-07-10cmdline: samba-tool test for bad option warningDouglas Bagnall1-0/+9
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz>
2024-07-09ldap_server: Add a ldapsrv debug class to log LDAP queriesAndréas Leroux1-1/+1
Patch updated for recent samba versions in merge request #3295 by kvvloten Initial patch created by Jeremy Allison (https://www.spinics.net/lists/samba/msg161128.html) to log LDAP server queries/functions in a separate file Signed-off-by: Andréas Leroux <aleroux@tranquil.it> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Tue Jul 9 08:37:22 UTC 2024 on atb-devel-224
2024-07-05tests: Use the general py_reparse_getVolker Lendecke1-1/+2
This was the only user of py_reparse_symlink_get Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2024-07-05tests: Remove a pointless ;Volker Lendecke1-1/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2024-07-02pyglue: Remove global variables used in only one placeJo Sutton1-21/+12
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Martin Schwenke <martin@meltin.net>
2024-07-02tests/krb5: Simplify code using dict.get()Jo Sutton1-20/+5
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Martin Schwenke <martin@meltin.net>
2024-07-02tests/krb5: Fix type errors by giving ‘pwd_last_set’ an appropriate typeJo Sutton1-2/+2
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Martin Schwenke <martin@meltin.net>
2024-06-27tests/krb5: Add tests for errors produced when logging in with unusable accountsJo Sutton1-2/+208
Heimdal matches Windows in the no‐FAST case, but produces NTSTATUS codes when it shouldn’t in the FAST case. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15655 Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2024-06-27tests/krb5: Allow creation of disabled accounts for testingJo Sutton1-2/+7
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15655 Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2024-06-13python/samba/tests/krb5: Add tests for password expiry with krb5 ENC-TSAndrew Bartlett2-2/+81
This augments the PKINIT based tests to show this is correctly handled for the fare more usual case. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: David Mulder <dmulder@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu Jun 13 00:45:36 UTC 2024 on atb-devel-224
2024-06-12python/samba/tests/krb5: Add check to confirm UF_SMARCARD_REQUIRED password ↵Andrew Bartlett1-0/+14
is expired on NTLM 8944a10b145e99eb6372cace8225e4c5e9d6160e broke password expiry checking on NTLM, but that is fixed after CID 1603594 triggered 815d696d4471f1b3a4267eb774eb80b07576031b. In the past we could not have password expiry times small enough to test expiry (unlike "must change now"), but having no test was not good. As we are already doing the sleep() here, add a test to the password rotation test. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: David Mulder <dmulder@samba.org>
2024-06-12python: remove string_to_byte_array()Douglas Bagnall2-13/+1
This was a useful function during the Python 2 -> 3 migration, but it is not used any more. In all the cases it was used, we knew we already had a bytes object, and this was just an inefficient way of confirming that. In cases where we actually want to cast a string into a mutable list of byte-sized ints, the builtin bytearray() function will do a better job than this, because it will encode high unicode characters as utf-8 bytes, rather than adding them as out-of-range values in the list. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Jun 12 09:16:39 UTC 2024 on atb-devel-224
2024-06-12samba-tool ldapcmp: remove a dodgy unused methodDouglas Bagnall1-26/+0
We have bindings for stringifying GUIDs, so I intended to replace this rather complicated code with that, but it turns out that this method has been unused since 5d42260eecfd4f26cc82637ce1bc989083c9eb9d in 2013. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-06-12pytest: simplify and fix HEXDUMP_FILTER used in hexdumpsDouglas Bagnall1-1/+2
The old test x if ((len(repr(chr(x))) == 3) and (x < 127)) else ord('.') went through some contortions to see if the character was printable, and it got it slightly wrong. The idea was that `repr(chr(97)` is "'a'", while `repr(chr(167)` is "'\xa7'", which we can distinguish using the length. But that miscategorised the backslash character, which is represented as "'\\'", a string of length 4, so it was show as '.' instead. Instead we notice that the characters we want to print in a hexdump are exactly those between 32 and 126, inclusive. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-06-12samba-tool domain trust: avoid useless use of string_to_byte_arrayDouglas Bagnall1-4/+4
`pw.encode('utf-16-le')` is always bytes. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-06-12python:lsa_utils: avoid useless use of py2-compat string_to_byte_arrayDouglas Bagnall1-6/+5
`pw.encode('utf-16-le')` is always bytes. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-06-12python:join: avoid useless use of py2-compat string_to_byte_arrayDouglas Bagnall1-3/+3
This was a workaround for the migration to Python 3, but is now just extra work for the computer and cognitive load for us. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-06-12py:emulate: remove py2 str/bytes workaround in traffic_packetsDouglas Bagnall1-4/+4
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-06-12py:emulate: remove py2 str/bytes workaround in trafficDouglas Bagnall1-2/+1
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-06-12pytest: remove py2 str/bytes workaround in auth_log_samlogonDouglas Bagnall1-6/+2
It is likely not necessary to cast to list() in most cases. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-06-12pytest: remove py2 str/bytes workaround in samr_change_passwordDouglas Bagnall1-1/+1
It is likely not necessary to cast to list(). Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-06-12pytest: remove py2 str/bytes workaround in lsa_utilsDouglas Bagnall1-6/+2
It is likely not necessary to cast to list() in most cases. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-06-12pytest: remove py2 str/bytes workaround in dns_baseDouglas Bagnall1-2/+2
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-06-12pytest: remove py2 str/bytes workaround in py_credentialsDouglas Bagnall1-5/+5
It is likely not necessary to cast to list() in most cases. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-06-11selftest: Add a python blackbox test for some misc (widelink) DFS testsNoel Power1-0/+86
On master attempting to chdir into a nested dfs link e.g. cd dfslink (works) cd dfslink/another_dfslink (fails) [1] Add a test for this scenario (nested chdir) [2] Add test for enumerating a dfs link in root of dfs share [3] Add a test to check case insensitive chdir into dfs link on widelink enabled share Add knownfails for tests 1 and 3 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=15435
2024-06-11samba-tool user readpasswords: avoid `assert` for validationDouglas Bagnall1-1/+4
`assert` can be optimised away if python is run with `-O`. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue Jun 11 05:32:28 UTC 2024 on atb-devel-224
2024-06-11ldb: Attach appropriate ldb context to returned resultJo Sutton1-1/+1
This is done by adding a new API that avoids the problems of ldb_dn_copy() and makes it clear that a struct ldb_context * pointer will be stored in the new copy. Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-06-10python/samba/tests/krb5: Allow ↵Andrew Bartlett1-1/+9
PkInitTests.test_pkinit_ntlm_from_pac_must_change_now to pass on Samba/Heimdal This flexiblity in the tests avoids requiring Samba/Heimdal to omit an NTSTATUS error return and just be consistent between the different authentication paths. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jo Sutton <josutton@catalyst.net.nz> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Mon Jun 10 05:32:54 UTC 2024 on atb-devel-224
generated by cgit v1.2.3 (git 2.25.1) at 2026-05-07 00:03:36 +0000