summaryrefslogtreecommitdiff
path: root/source3/libsmb
AgeCommit message (Collapse)AuthorFilesLines
2019-06-20libsmb: Make cli_lockingx cancellableVolker Lendecke1-0/+16
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-06-20lib: Fix a typoVolker Lendecke1-1/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-06-18libsmb: Use cli_lockingx() in cli_unlock()Volker Lendecke1-26/+20
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2019-06-18libsmb: Use cli_lockingx() in cli_locktype()Volker Lendecke1-34/+15
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2019-06-18libsmb: Use cli_lockingx() in cli_oplock_ack()Volker Lendecke1-24/+17
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2019-06-18libsmb: Add async cli_lockingx()Volker Lendecke2-0/+254
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2019-06-18libsmb: Remove unused is_andx_reqVolker Lendecke2-26/+0
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2019-06-18libsmb: Remove unused cli_[un]lock64()Volker Lendecke2-179/+0
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2019-06-18libsmb: Align integer typesVolker Lendecke1-1/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2019-05-19s3: libsmbclient: Fix return value if cli_open() failsRikard Falkeborn1-1/+1
Returning -1 in a function with bool as return value type is the same as returning true. Change to false to indicate the error. Detected by the help of cppcheck. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Reviewed-by: Ralph Böhme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-05-16s3: squash 'cast between incompatible function types' warningNoel Power1-10/+15
Some functions (e.g. py_smb_savefile) have an extra unecessary *kwargs param in their signatures, these definitions are causing 'cast between incompatible function types' warnings when compiled with -Wcast-function-type. Some other functions have the *kwargs which causes "cast between incompatible function types' warnings which need to be squashed with use of the PY_DISCARD_FUNC_SIG macro. Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org>
2019-05-15s3:libsmb: Add missing OOM check in fill_quota_buffer()Andreas Schneider1-1/+7
Found by covscan (csbuild). Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Noel Power <nopower@suse.com> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed May 15 00:45:58 UTC 2019 on sn-devel-184
2019-04-29s3:libsmb: Fix C99 initializer in cli_smb2_fnum.cAndreas Schneider1-3/+3
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
2019-04-02s3:libsmb: Add some useful debug output to cliconnectAndreas Schneider1-0/+13
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13861 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2019-04-01libsmb: Make cli_posix_chown/chmod proper tevent_req functionsVolker Lendecke1-10/+72
This prepares for making them smb2-aware Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Mon Apr 1 19:00:11 UTC 2019 on sn-devel-144
2019-04-01libsmb: Rename InfoType from [MS-SMB2] according to the specVolker Lendecke1-2/+2
This makes it easier to find this via internet search Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-27libsmb: Change cli_posix_readlink to return talloc'ed targetVolker Lendecke2-53/+50
This is a deviation from the Posix readlink function that from my point of view makes this function easier to use. In Posix, probably the assumption is that readlink is cheap, so someone under memory constraints could just start with a small buffer and incrementally increase the buffer size. For us, it's a network round-trip, and we have the luxury of [mt]alloc, which the syscall kernel interface does not have. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Mar 27 12:31:37 UTC 2019 on sn-devel-144
2019-03-27libsmb: Don't pass "cli" to cli_posix_readlink_recvVolker Lendecke2-12/+17
From my point of view the option to change "cli" between cli_posix_readlink_send and _recv is not necessary. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-27libsmb: Rename "readlink_state" to "cli_posix_readlink_state"Volker Lendecke1-6/+8
This is more in line with most other users of tevent_req: The state is called fully after the routines it acts as a state repository for. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-27libsmb: Fix valgrind errors in cli_smb2_get_reparse_pointVolker Lendecke1-2/+4
Both tevent_req_nterror and tevent_req_is_nterror invalidate "state". Pull the variables out of "state" before calling those two functions. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-26libsmb: Fix cli_smb2_get_reparse_point_fnum_sendVolker Lendecke1-1/+1
Use the correct state variable type Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2019-03-20libsmb: Make SMB1-only cli_nt_hardlink calls staticVolker Lendecke2-48/+2
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Mar 20 23:32:31 UTC 2019 on sn-devel-144
2019-03-20libsmb: Introduce protocol-agnostic cli_hardlinkVolker Lendecke2-1/+248
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-20libsmb: Use cli_smb2_set_info_fnum()Volker Lendecke1-135/+56
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-20libsmb: Simplify cli_smb2_ftruncateVolker Lendecke1-8/+3
We don't need to talloc 8 bytes, they can live on the stack. When we go async, this can go into the state struct. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-20libsmb: Simplify cli_smb2_delete_on_closeVolker Lendecke1-21/+10
Use cli_smb2_set_info_fnum, remove "state" variables Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-20libsmb: Add cli_smb2_set_info_fnumVolker Lendecke2-0/+127
This wraps getting the file handle from the fnum Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-18libsmb: Fix a "assuming signed overflow does not occur" errorVolker Lendecke1-3/+4
Eventually we need to convert internal_resolve_name to "size_t" for "return_count". But that's a patch for another day :-) Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2019-03-18libsmb: Align integer typesVolker Lendecke1-1/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2019-03-18libsmb: Use cli_smb2_query_info_fnumVolker Lendecke1-238/+133
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-18libsmb: Add cli_smb2_query_info_fnumVolker Lendecke2-0/+179
This wraps getting the file handle from the fnum Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-18libsmb: Change cli_posix_stat_send to take a pointer to sbufVolker Lendecke2-41/+60
This moves the parsing work from the _recv function into the _done function. This makes writing the SMB2 call easier later on: We can have a smb2-specific done function doing the smb2-specific work and we don't have to fork on protocol in the _recv function. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-18libsmb: Make cli_posix_[sym|hard]link proper tevent_req functionsVolker Lendecke1-3/+60
Simplify adding SMB2 to those functions Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-18libsmb: Use tevent_req_simple_finish_ntstatusVolker Lendecke1-10/+3
Less lines of code Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-12libsmb: Use sid_parse()Volker Lendecke1-16/+3
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2019-03-08libsmb: Use tevent_req_simple_finish_ntstatusVolker Lendecke1-5/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Mar 8 19:16:18 UTC 2019 on sn-devel-144
2019-03-08libsmb: Add "in_cblobs" to cli_smb2_unlinkVolker Lendecke3-8/+18
This reveals the fact that unlink is an open/close in smb2 through the API. This is not nice, but it's an internal API with currently only one user. And it enables posix semantics for the open easily. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-08libsmb: Add "in_cblobs" to cli_smb2_rmdirVolker Lendecke3-14/+26
This reveals the fact that rmdir is an open/close in smb2 through the API. This is not nice, but it's an internal API with currently only one user. And it enables posix semantics for the open easily. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-08libsmb: Make cli_smb2_unlink asyncVolker Lendecke2-35/+154
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-08libsmb: Simplify cli_smb2_mxacVolker Lendecke1-12/+5
smb2_create_blob_find() can search for a create blob for us Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-04s3:libsmb: add cli_query_mxac()Ralph Boehme2-0/+16
Works only for SMB2. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-04s3:libsmb: add cli_smb2_query_mxac()Ralph Boehme2-0/+199
Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-02libsmb: Make cli_posix_unlink/rmdir proper tevent_req/subreq pairsVolker Lendecke1-5/+58
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Mar 2 00:55:56 UTC 2019 on sn-devel-144
2019-03-01libsmb: Use tevent_req_simple_finish_ntstatus()Volker Lendecke1-5/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-01libsmb: Use tevent_req_simple_finish_ntstatus()Volker Lendecke1-9/+2
Less lines... Just rediscovered this function :-) Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-01libsmb: Make cli_smb2_rmdir asynchronousVolker Lendecke2-43/+185
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Mar 1 01:30:35 UTC 2019 on sn-devel-144
2019-03-01libsmb: add in/out cblobs to cli_smb2_create_fnumVolker Lendecke3-20/+116
This is driven by the imminent smb2 unix extensions, we'll want to make use of it from source3/libsmb. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-01libsmb: Avoid a separate "cblobs" var sending smb2 createVolker Lendecke1-9/+7
Less lines of code, and we will add custom cblobs soon. This change makes that logic easier. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-03-01libsmb: Reformat the cli_smb2_create_fnum_send argsVolker Lendecke3-52/+70
We'll add parameters in the next commit, make that commit a bit more obvious Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-02-25libsmb: Resolve special _recv handling in cli_ntcreateVolker Lendecke1-12/+28
cli_smb2_create_fnum_recv will gain output create blobs soon and thus differ from the NT1 function. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
generated by cgit v1.2.3 (git 2.25.1) at 2026-06-26 06:16:33 +0000