summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2019-11-15s3-build: add missing gnutls dependencyBjörn Baumbach1-1/+4
Signed-off-by: Björn Baumbach <bb@sernet.de> Reviewed-by: Andreas Schneider <asn@samba.org>
2019-11-14vfs: Use dbwrap_delete() in acl_tdb_delete()Volker Lendecke1-30/+4
Use the wrapper function that's already available for exactly this purpose. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-14vfs: Use dbwrap_store() in store_acl_blob_fsp()Volker Lendecke1-9/+4
Use the wrapper function that's already available for exactly this purpose. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-14vfs: Use direct struct assignment in store_acl_blob_fsp()Volker Lendecke1-3/+1
2 lines less code Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-13smbd: Make share_mode_do_locked() pass TDB_DATA instead of a recordVolker Lendecke3-12/+14
No callback used (and should not use) the record directly, this is all handled within share_mode_lock.c Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Nov 13 21:41:09 UTC 2019 on sn-devel-184
2019-11-13build: Only link against libcrypt where neededAndrew Bartlett1-0/+1
Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: David Mulder <dmulder@suse.com> Reviewed-by: Andreas Schneider <asn@samba.org>
2019-11-13s3-build: Skip building the ndr_table at the tail of ndr_libnetapi.cAndrew Bartlett1-0/+1
This is not a real protocol and all the functions are set to nopull,nopush but do not supply replacement functions. This is the best was I could find to skip compiling the table as otherwise it would point to undefined functions. This does not happen until we generate the ndr_table for idl files without a UUID, but we will shortly do that. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191 Signed-off-by: Andrew Bartlett <abartlet@samba.org> signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Pair-progammed-with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2019-11-13build: Allow warning on compile of libnetapi PIDLAndrew Bartlett1-1/+2
This not-protocol only uses the print functions, but this means some other functions are now unused, and as this is a special case it is better to just allow warnings here. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2019-11-13librpc: Do not include the ndr_table for libnet_join.idl and libnetapi.idl ↵Andrew Bartlett1-2/+9
in the global list These are not wire protocols, there are no structures to parse. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Pair-progammed-with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2019-11-13smbd: Remove write cacheVolker Lendecke16-886/+8
Since this was written, our write path has changed significantly. In particular we have gained very flexible support for async I/O, with the linux io_uring in the pipeline. Caching stuff in main memory and then doing a blocking pwrite nowadays does not belong into the core smbd code. If someone wants it back, it should be doable in a VFS module. Removes: "write cache size" parameter. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Nov 13 00:20:55 UTC 2019 on sn-devel-184
2019-11-12lib: Remove unused file_id_string()Volker Lendecke2-12/+0
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Nov 12 22:18:40 UTC 2019 on sn-devel-184
2019-11-12smbd: Use file_id_str_buf() in share_mode_cleanup_disconnected()Volker Lendecke1-6/+6
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-12smbd: Use file_id_str_buf() in share_mode_memcache_fetch()Volker Lendecke1-7/+8
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-12smbd: Use file_id_str_buf() in share_mode_memcache_store()Volker Lendecke1-1/+2
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-12lib: Remove unused file_id_string_tos()Volker Lendecke2-12/+0
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-12torture3: Use file_id_str_buf() in print_brl()Volker Lendecke1-1/+4
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-12smbd: Use file_id_str_buf() in linux_release_kernel_oplock()Volker Lendecke1-2/+4
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-12smbd: Use file_id_str_buf() in linux_oplock_signal_handler()Volker Lendecke1-6/+9
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-12smbd: Use file_id_str_buf() in scavenger_add_timer()Volker Lendecke1-3/+4
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-12smbd: Use file_id_str_buf() in file_find_dif()Volker Lendecke1-1/+2
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-12smbd: Use file_id_str_buf() in scavenger_timer()Volker Lendecke1-11/+13
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-12smbd: Use file_id_str_buf() in scavenger_schedule_disconnected()Volker Lendecke1-1/+2
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-12s3: smbd: smb2 cleanup - restructure smbd_smb2_request_pending_timer() ↵Jeremy Allison1-9/+9
encrypt code to look the same as smbd_smb2_request_reply(). This makes code changes in both (if needed) much easier to spot. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2019-11-12s3: smbd: smb2 cleanup - remove variable tf_len - this is a constant ↵Jeremy Allison1-3/+2
SMB2_TF_HDR_SIZE. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2019-11-12s3: smbd: SMB2 - Ensure we use the correct session_id if encrypting an ↵Jeremy Allison1-1/+1
interim response. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14189 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2019-11-12Detect when command line max protocol < min protocolDavid Mulder1-0/+14
Due to the increased default minimum protocol level to SMB2, some users notice that specifying smbclient -m NT1 fails with NT_STATUS_CONNECTION_DISCONNECTED, with no SMB traffic on the wire. Report when the max protocol is set less than the min protocol. Signed-off-by: David Mulder <dmulder@suse.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Noel Power <npower@samba.org> Autobuild-User(master): Noel Power <npower@samba.org> Autobuild-Date(master): Tue Nov 12 17:52:28 UTC 2019 on sn-devel-184
2019-11-07s3:printing: Fix %J substitionRalph Boehme3-13/+16
print_run_command() uses lp_print_command() which internally performs basic substition by calling talloc_sub_basic(). As a result. any of the variables in the "basic set", including "%J" are already substituted. To prevent the unwanted subtitution, we declare all affected configuration options as const, which disabled the basic substition. As a result print_run_command() can run manual substitution on all characters, including %J, in the variadic argument list *before* calling lp_string() to run basic substition which we had disabled before with the const. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Nov 7 16:01:21 UTC 2019 on sn-devel-184
2019-11-07s3:printing: add a DEBUG statementRalph Boehme1-0/+2
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2019-11-07s3:lib: factor out talloc_sub_advanced() from talloc_sub_full()Ralph Boehme2-5/+27
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2019-11-07s3: rename talloc_sub_advanced() to talloc_sub_full()Ralph Boehme11-24/+24
We currently have the following substitution functions: talloc_sub_basic() talloc_sub_advanced() talloc_sub_basic() currently substitutes a subset of talloc_sub_advanced(). We'll need a function X that only substitutes what talloc_sub_advanced() substitutes *without* what talloc_sub_basic() does. To get there rename talloc_sub_advanced() to talloc_sub_full(). A subsequent commit will then bring back talloc_sub_advanced() as described above. Examples with fictional replacement letters A and B. Currently: talloc_sub_basic: A talloc_sub_advanced: AB New: talloc_sub_basic: A talloc_sub_advanced: B talloc_sub_full: AB BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2019-11-07s3: remove unused function standard_sub_advanced()Ralph Boehme2-20/+0
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2019-11-07s3: replace standard_sub_advanced with talloc_sub_advanced in one placeRalph Boehme1-4/+10
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2019-11-07s3:printing: fix a long lineRalph Boehme1-1/+2
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2019-11-06vfs: Use file_id_str_buf() in vfs_delay_inject_brl_lock_timer()Volker Lendecke1-1/+2
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Nov 6 21:58:52 UTC 2019 on sn-devel-184
2019-11-06smbd: Use struct initialization instead of ZERO_STRUCT()Volker Lendecke1-3/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-06vfs: Use file_id_str_buf() in smb_full_audit_file_id_create()Volker Lendecke1-1/+4
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-06smbd: Use file_id_str_buf() in set_write_time()Volker Lendecke1-2/+3
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-06smbd: Use file_id_str_buf() in rename_open_files()Volker Lendecke1-7/+12
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-06smbd: Use file_id_str_buf() in contend_level2_oplocks_begin_default()Volker Lendecke1-1/+2
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-06smbd: Use file_id_str_buf() in process_kernel_oplock_break()Volker Lendecke1-3/+5
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-06smbd: Use file_id_str_buf() in process_oplock_break_message()Volker Lendecke1-7/+9
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-06smbd: Use file_id_str_buf() in initial_break_processing()Volker Lendecke1-9/+13
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-06smbd: Use file_id_str_buf() in downgrade_lease()Volker Lendecke1-8/+17
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-06smbd: Use file_id_str_buf() in downgrade_oplock()Volker Lendecke1-4/+6
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-06smbd: Use file_id_str_buf() in set_file_oplock()Volker Lendecke1-2/+4
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-06smbd: Use file_id_str_buf() in set_file_oplock()Volker Lendecke1-1/+2
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-06ntlm_auth: Fix nonempty line endingsVolker Lendecke1-64/+64
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-06ntlm_auth: Simplify session generationVolker Lendecke1-16/+3
We don't need to parse a text sid, we have those as binary available Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-06lib: Avoid includes.h in g_lock.cVolker Lendecke1-1/+5
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-11-06lib: Remove g_lock_do()Volker Lendecke2-68/+0
This puts too much logic into this lowlevel infrastructure module, given the two minor external users. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
generated by cgit v1.2.3 (git 2.25.1) at 2026-06-10 16:05:16 +0000