summaryrefslogtreecommitdiff
path: root/source4/scripting
AgeCommit message (Collapse)AuthorFilesLines
2015-05-29KCC: post-Kruskal graph test only needs multi-edge-forestDouglas Bagnall1-1/+1
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: move ldif import/export functions into their own moduleDouglas Bagnall1-339/+9
They might be of use elsewhere, and they are easily separable from the KCC core. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: rearrange samba_kcc entry pointDouglas Bagnall1-21/+22
For locality, so that it becomes clearer which variables are used where. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: move import to top of fileDouglas Bagnall1-1/+1
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: add an option to list valid DSA dn_strsDouglas Bagnall1-4/+30
This makes testing a bit easier. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC graph_utils: rename KCCGraphError, GraphErrorDouglas Bagnall1-1/+1
In case it gets used elsewhere. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: try graphing edges in colour for partition typeDouglas Bagnall1-2/+5
It doesn't add much. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: shift graph plotting and verification into a separate moduleDouglas Bagnall1-0/+1
These might possibly be useful outside the KCC context, and the don't rely on the rest of kcc_utils. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: more graph verification: repsFromDouglas Bagnall1-4/+56
Some of these graphs are wrong headed and broken Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: the commit that mops up stray commentsDouglas Bagnall1-1/+3
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: add --attempt-live-connections to verify real life linksDouglas Bagnall1-8/+23
The spec makes these connections in a couple of places. That makes no sense in our main testing environment which is a samba database pretending to be a network. The default should be changed to True when failed link detection is implemented. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: make --verify graph errors fatalDouglas Bagnall1-2/+7
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: attempt to use correct verification tests for graphsDouglas Bagnall1-7/+4
Before they were liberally assigned because the failures were as interesting as the passes. Also add a stub for the forest_of_rings test. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: debug nc_type by name rather than enum numberDouglas Bagnall1-2/+2
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: sitelink graph is undirectedDouglas Bagnall1-1/+1
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: use ndr_pack for connection GUID comparisonsDouglas Bagnall1-1/+2
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: consistently use ndr_pack() for DSA GUID comparisonsDouglas Bagnall1-4/+1
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: Use ndrpack(GUID) sorting for all graph vertex operationsDouglas Bagnall1-1/+3
For intrasite rings, DSA GUIDs are sorted by their ndr_pack representation, not their string/as-if-128-bit-int representation. Supposing some consistency across KCC, the graph vertex guids might be compared the same way. But we don't yet know for sure. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29kcc: reduce brokenness of --import-lidfAndrew Bartlett1-4/+35
It still doesn't combine well with --forced-local-dsa, due it seems to pervasive fragile cross-dependencies within the ldb system. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: skip looking for extra edges if we have enoughDouglas Bagnall1-1/+1
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: A whole lot of debugging and other non-functional changesDouglas Bagnall1-10/+43
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29kcc: sort guids by ndr_pack representationDouglas Bagnall1-1/+1
This gives the correct rings in intrasite. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: rewrite random intrasite connection addition for clarityDouglas Bagnall1-28/+16
And add debug messages. No change in results though. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: intrasite_post_ntdscon is directedDouglas Bagnall1-1/+1
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: add NC identifiers to dot file namesDouglas Bagnall1-2/+4
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: Fix original script for inverted logicGarming Sam1-1/+1
Signed-off-by: Garming Sam <garming@catalyst.net.nz> Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: rename "fully_connected" check, "complete"Douglas Bagnall1-12/+12
We also change some of the graphs to do only the relevent validations. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: Set option --readonly to default to FalseDouglas Bagnall1-1/+1
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: add directed double ring verificationDouglas Bagnall1-1/+2
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: add an option to list the graph verification optionsDouglas Bagnall1-2/+7
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: comment noting the progression of edge limit calculationDouglas Bagnall1-0/+8
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: add a wider range of colour DEBUG messagesDouglas Bagnall1-9/+12
and use them in a couple of places, for no good reason. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: add graph verification at all dot file pointsDouglas Bagnall1-35/+75
The tests are not yet relevant. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-29KCC: add an option to verify graph propertiesDouglas Bagnall1-7/+27
Any function with a name in the form "verify_graph_FOO" will be available as a graph verification option (with the property name "FOO"). The signature is "verify_graph_FOO(edges, vertices, edge_vertices)", where edge_vertices is the set of vertices found on the edges, while vertices is the set of vertices given to verify_graph (or a copy of edge_vertices if no such set was given). This makes it easier to add new tests without making the function too unwieldy. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-28KCC: Write out more DOT files and debugDouglas Bagnall1-1/+17
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-28KCC: Comment noting verbose nature of construct_intrasite_graph()Douglas Bagnall1-4/+4
Signed-off-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-28KCC: add --forced-local-dsa option for changing local dsaAndrew Bartlett1-5/+15
For testing it is useful to pretend a DSA is local against the preferences of the database. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2015-05-28KCC: add comments, idiomatic changes to intrasite_graph codeDouglas Bagnall1-6/+36
Using `x in foo_dict.keys()` is the same as `x in foo_dict`, except it is O(n) instead of O(1) and is not the way things are done in Python. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-28KCC: improve log legibility with colour; make more dot graphsDouglas Bagnall1-5/+52
To see the colours in less, use -R. bin/samba_kcc --debug -H whatever/sam.ldb | less -R Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-28samba_kcc: try to implement rep deletion in translate_ntdsconn()Douglas Bagnall1-7/+17
The trouble is it does nothing in our test case as there are no reps that need deleting. Also adding some tidy-ups and pointers to the reference. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-28kcc: add labels to dot filesDouglas Bagnall1-2/+3
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-28KCC: highlight our deviation from the spec in color_verticesDouglas Bagnall1-3/+10
The documentation didn't make much sense. Worked out by Garming. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-28samba_kcc: add an option to set assumed current timeDouglas Bagnall1-5/+26
The KCC algorithm contains a timeouts in a couple of places, and we need to be able to set the time for testing these. This also means samba_kcc uses the same time in all places. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-28KCC: Create Graphviz dot files showing network topologyDouglas Bagnall1-4/+23
This tries to record some information about what the graph is (e.g which partition), though it is not very readable. Pair-programmed-with: Garming Sam <garming@catalyst.net.nz> Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-28kcc: Add a TODO for is_bridgehead_failedGarming Sam1-1/+1
Signed-off-by: Garming Sam <garming@catalyst.net.nz> Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-28kcc: add some more debug messagesGarming Sam1-0/+2
Signed-off-by: Garming Sam <garming@catalyst.net.nz> Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-28kcc: correctly calculate the number of componentsGarming Sam1-1/+1
Signed-off-by: Garming Sam <garming@catalyst.net.nz> Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-28kcc: Export extended_dn to be used by importGarming Sam1-1/+2
Signed-off-by: Garming Sam <garming@catalyst.net.nz> Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-28kcc: Make debugging slightly clearerGarming Sam1-2/+2
Signed-off-by: Garming Sam <garming@catalyst.net.nz> Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-05-28kcc: Use remote vertex instead of local vertex in getting bridgeheadGarming Sam1-3/+12
Signed-off-by: Garming Sam <garming@catalyst.net.nz> Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>