summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeff Layton <jlayton@samba.org>2011-07-29 07:12:48 -0400
committerJeff Layton <jlayton@samba.org>2011-07-29 07:12:48 -0400
commit1e7a32924b22d1f786b6f490ce8590656f578f91 (patch)
tree5933cde61b0230836d486123cbfce108779694d9
parent861824f588a870da7c110b6f199eb5ce7d4dc476 (diff)
downloadcifs-utils-1e7a32924b22d1f786b6f490ce8590656f578f91.tar.gz
cifs-utils-1e7a32924b22d1f786b6f490ce8590656f578f91.tar.bz2
cifs-utils-1e7a32924b22d1f786b6f490ce8590656f578f91.zip
mount.cifs: check_newline returns EX_USAGE on error, not -1
Reported-by: Jan Lieskovsky <jlieskov@redhat.com> Signed-off-by: Jeff Layton <jlayton@samba.org>
-rw-r--r--mount.cifs.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/mount.cifs.c b/mount.cifs.c
index 107a5a5..aa4581f 100644
--- a/mount.cifs.c
+++ b/mount.cifs.c
@@ -1419,8 +1419,7 @@ static int check_newline(const char *progname, const char *name)
static int check_mtab(const char *progname, const char *devname,
const char *dir)
{
- if (check_newline(progname, devname) == -1 ||
- check_newline(progname, dir) == -1)
+ if (check_newline(progname, devname) || check_newline(progname, dir))
return EX_USAGE;
return 0;
}