summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeff Layton <jlayton@samba.org>2011-09-23 12:51:28 -0400
committerJeff Layton <jlayton@samba.org>2011-09-23 12:51:28 -0400
commit3956417185b257b877184b04e035254000e8eafe (patch)
tree1f3bc2c503124a34eaacac4b1b41788b088f5302
parent6f8711840e0a812ffa5140243d3adfe0aed64e98 (diff)
downloadcifs-utils-3956417185b257b877184b04e035254000e8eafe.tar.gz
cifs-utils-3956417185b257b877184b04e035254000e8eafe.tar.bz2
cifs-utils-3956417185b257b877184b04e035254000e8eafe.zip
setcifsacl: remove unused rc var from build_cmdline_aces
...and eliminate this build warning: setcifsacl.c: In function ‘build_cmdline_aces’: setcifsacl.c:582:9: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable] Signed-off-by: Jeff Layton <jlayton@samba.org>
-rw-r--r--setcifsacl.c8
1 files changed, 1 insertions, 7 deletions
diff --git a/setcifsacl.c b/setcifsacl.c
index d0da34a..502c839 100644
--- a/setcifsacl.c
+++ b/setcifsacl.c
@@ -579,7 +579,7 @@ verify_ace_mask(char *maskstr, uint32_t *maskval)
static struct cifs_ace **
build_cmdline_aces(char **arrptr, int numcaces)
{
- int i, rc = 0;
+ int i;
char *acesid, *acetype, *aceflag, *acemask;
struct cifs_ace **cacesptr;
@@ -598,41 +598,35 @@ build_cmdline_aces(char **arrptr, int numcaces)
if (!acesid || !acetype || !aceflag || !acemask) {
printf("%s: Incomplete ACE: %s\n", __func__, arrptr[i]);
- rc = 1;
goto build_cmdline_aces_ret;
}
cacesptr[i] = malloc(sizeof(struct cifs_ace));
if (!cacesptr[i]) {
printf("%s: ACE alloc error %d\n", __func__, errno);
- rc = errno;
goto build_cmdline_aces_ret;
}
if (verify_ace_sid(acesid, &cacesptr[i]->sid)) {
printf("%s: Invalid SID: %s\n", __func__, arrptr[i]);
- rc = 1;
goto build_cmdline_aces_ret;
}
if (verify_ace_type(acetype, &cacesptr[i]->type)) {
printf("%s: Invalid ACE type: %s\n",
__func__, arrptr[i]);
- rc = 1;
goto build_cmdline_aces_ret;
}
if (verify_ace_flags(aceflag, &cacesptr[i]->flags)) {
printf("%s: Invalid ACE flag: %s\n",
__func__, arrptr[i]);
- rc = 1;
goto build_cmdline_aces_ret;
}
if (verify_ace_mask(acemask, &cacesptr[i]->access_req)) {
printf("%s: Invalid ACE mask: %s\n",
__func__, arrptr[i]);
- rc = 1;
goto build_cmdline_aces_ret;
}