diff options
| author | Aurelien Aptel <aaptel@suse.com> | 2018-08-08 11:38:15 +0200 |
|---|---|---|
| committer | Pavel Shilovsky <pshilov@microsoft.com> | 2018-08-17 11:01:39 -0700 |
| commit | 77b028c11fee787d1235a08fd06c8b60d20eb9c0 (patch) | |
| tree | 04f7fdced27c83c914f8e950d960d124b86b8560 | |
| parent | a389756f51916995d27819ea1807ab03f36d8dd7 (diff) | |
| download | cifs-utils-77b028c11fee787d1235a08fd06c8b60d20eb9c0.tar.gz cifs-utils-77b028c11fee787d1235a08fd06c8b60d20eb9c0.tar.bz2 cifs-utils-77b028c11fee787d1235a08fd06c8b60d20eb9c0.zip | |
checkopts: report duplicated options in man page
Signed-off-by: Aurelien Aptel <aaptel@suse.com>
| -rwxr-xr-x | checkopts | 19 |
1 files changed, 16 insertions, 3 deletions
@@ -98,9 +98,12 @@ def extract_man_opts(fn): state = STATE_BASE rx = RX() opts = {} + ln = 0 with open(fn) as f: for s in f.readlines(): + ln += 1 + if state == STATE_EXIT: break @@ -113,7 +116,9 @@ def extract_man_opts(fn): s = chomp(s) names = extract_canonical_opts(s) for name in names: - opts[name] = s + if name not in opts: + opts[name] = [] + opts[name].append({'ln':ln, 'fmt':s}) elif rx.search(r'^[A-Z]+', s): state = STATE_EXIT return opts @@ -174,6 +179,14 @@ def main(): def opt_is_doc(o): return o in manopts + print('DUPLICATED DOC OPTIONS') + print('======================') + + for opt in sortedset(man_opts_set): + if len(manopts[opt]) > 1: + lines = ", ".join([str(x['ln']) for x in manopts[opt]]) + print("OPTION %-20.20s (lines %s)"%(opt, lines)) + print() print('UNDOCUMENTED OPTIONS') print('====================') @@ -208,8 +221,8 @@ def main(): unex_opts = man_opts_set - kernel_opts_set # group opts and their negations together for opt in sortedset(unex_opts): - fmt = manopts[opt] - print('OPTION %s ("%s")' % (opt, fmt)) + man = manopts[opt][0] + print('OPTION %s ("%s") line %d' % (opt, man['fmt'], man['ln'])) print('') |