diff options
| author | Jeff Layton <jlayton@samba.org> | 2013-10-09 08:14:21 -0400 |
|---|---|---|
| committer | Jeff Layton <jlayton@samba.org> | 2013-10-10 08:26:21 -0400 |
| commit | 930b724e784c28bd1b3024f7fc6ca24cdac82a4d (patch) | |
| tree | 26f25c51842807314b46d59953fdd5f961fb60c4 | |
| parent | 99d2a5a4517216a63cfdeef3ee30656938b3a98e (diff) | |
| download | cifs-utils-930b724e784c28bd1b3024f7fc6ca24cdac82a4d.tar.gz cifs-utils-930b724e784c28bd1b3024f7fc6ca24cdac82a4d.tar.bz2 cifs-utils-930b724e784c28bd1b3024f7fc6ca24cdac82a4d.zip | |
getcifsacl: remove some dead code
Coverity says:
Error: DEADCODE (CWE-561): [#def5]
cifs-utils-6.2/getcifsacl.c:101: assignment: Assigning: "mflags" = "false".
cifs-utils-6.2/getcifsacl.c:109: const: At condition "mflags", the value of "mflags" must be equal to 0.
cifs-utils-6.2/getcifsacl.c:109: dead_error_condition: The condition "mflags" cannot be true.
cifs-utils-6.2/getcifsacl.c:110: dead_error_line: Execution cannot reach this statement "printf("|");".
Acked-by: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Signed-off-by: Jeff Layton <jlayton@samba.org>
| -rw-r--r-- | getcifsacl.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/getcifsacl.c b/getcifsacl.c index 33f36b4..f08cdea 100644 --- a/getcifsacl.c +++ b/getcifsacl.c @@ -106,10 +106,7 @@ print_ace_flags(uint8_t flags, int raw) } if (flags & OBJECT_INHERIT_FLAG) { - if (mflags) - printf("|"); - else - mflags = true; + mflags = true; printf("OI"); } if (flags & CONTAINER_INHERIT_FLAG) { |