diff options
author | Martin Schwenke <martin@meltin.net> | 2020-09-25 11:16:39 +1000 |
---|---|---|
committer | Pavel Shilovsky <pshilov@microsoft.com> | 2020-11-09 15:15:25 -0800 |
commit | 1252355e7c422e5f40e93c1b5c681f8f90a83d47 (patch) | |
tree | b147efd4acc53540a63431721de059d38cc9d189 /mount.cifs.c | |
parent | ff54e6fbb4571c82e93118c569f8152d4bebea6f (diff) | |
download | cifs-utils-1252355e7c422e5f40e93c1b5c681f8f90a83d47.tar.gz cifs-utils-1252355e7c422e5f40e93c1b5c681f8f90a83d47.tar.bz2 cifs-utils-1252355e7c422e5f40e93c1b5c681f8f90a83d47.zip |
mount.cifs: ignore comment mount option
mount.cifs currently complains about the "comment" option:
CIFS: Unknown mount option "comment=foo"
mount(8) on Linux says:
The command mount does not pass the mount options unbindable,
runbindable, private, rprivate, slave, rslave, shared, rshared,
auto, noauto, comment, x-*, loop, offset and sizelimit to the
mount.<suffix> helpers.
So if mount.cifs decides to re-read /etc/fstab it should ignore the
comment option.
A lot of online posts say to use comment=x-gvfs-show as an option to
have a Linux file manager display a mountpoint for a user mountable
filesystem. While the "comment=" part is superfluous when combined
with an x-* option, the problem is still difficult to debug.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Diffstat (limited to 'mount.cifs.c')
-rw-r--r-- | mount.cifs.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/mount.cifs.c b/mount.cifs.c index 4feb397..5d43c00 100644 --- a/mount.cifs.c +++ b/mount.cifs.c @@ -777,6 +777,8 @@ static int parse_opt_token(const char *token) return OPT_BKUPGID; if (strcmp(token, "nofail") == 0) return OPT_NOFAIL; + if (strcmp(token, "comment") == 0) + return OPT_IGNORE; if (strncmp(token, "x-", 2) == 0) return OPT_IGNORE; if (strncmp(token, "snapshot", 8) == 0) |