summaryrefslogtreecommitdiff
path: root/setcifsacl.c
diff options
context:
space:
mode:
authorAlexander Bokovoy <ab@samba.org>2022-02-16 13:58:24 +0200
committerPavel Shilovsky <pshilovsky@samba.org>2022-04-29 15:07:49 -0700
commit4ad2c50f8f22968abe84a84ef49d37806731b20e (patch)
tree77cb6f2eac1cff7583df3a844264e27353384f7d /setcifsacl.c
parent9b074dbfc879145fd53a2108cdf8ba1baa2af956 (diff)
downloadcifs-utils-4ad2c50f8f22968abe84a84ef49d37806731b20e.tar.gz
cifs-utils-4ad2c50f8f22968abe84a84ef49d37806731b20e.tar.bz2
cifs-utils-4ad2c50f8f22968abe84a84ef49d37806731b20e.zip
setcifsacl: fix comparison of actions reported by covscan
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Diffstat (limited to 'setcifsacl.c')
-rw-r--r--setcifsacl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/setcifsacl.c b/setcifsacl.c
index 9840b14..c0ecd41 100644
--- a/setcifsacl.c
+++ b/setcifsacl.c
@@ -1497,7 +1497,7 @@ cifsacl:
numfaces = get_numfaces((struct cifs_ntsd *)attrval, attrlen,
&aclptr, ace_kind);
- if (!numfaces && (maction != ActAdd || maction != ActAddReorder)) {
+ if (!numfaces && (maction != ActAdd && maction != ActAddReorder)) {
/* if we are not adding aces */
fprintf(stderr, "%s: Empty DACL\n", __func__);
goto setcifsacl_facenum_ret;