diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2024-09-23 10:38:11 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-04-10 14:29:43 +0200 |
| commit | 2414095a8c1b04657df9308855b6a42894f8bfb6 (patch) | |
| tree | caa1e16f16f314ad79fd5b5ad10c0ebce51872f5 | |
| parent | a1ef4447b82bc74ce5a61e69708270ba61feb7dc (diff) | |
| download | linux-2414095a8c1b04657df9308855b6a42894f8bfb6.tar.gz linux-2414095a8c1b04657df9308855b6a42894f8bfb6.tar.bz2 linux-2414095a8c1b04657df9308855b6a42894f8bfb6.zip | |
ntb_perf: Delete duplicate dmaengine_unmap_put() call in perf_copy_chunk()
commit 4279e72cab31dd3eb8c89591eb9d2affa90ab6aa upstream.
The function call “dmaengine_unmap_put(unmap)” was used in an if branch.
The same call was immediately triggered by a subsequent goto statement.
Thus avoid such a call repetition.
This issue was detected by using the Coccinelle software.
Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support")
Cc: stable@vger.kernel.org
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/ntb/test/ntb_perf.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c index 251fe75798c1..cd0b5023f7f2 100644 --- a/drivers/ntb/test/ntb_perf.c +++ b/drivers/ntb/test/ntb_perf.c @@ -838,10 +838,8 @@ static int perf_copy_chunk(struct perf_thread *pthr, dma_set_unmap(tx, unmap); ret = dma_submit_error(dmaengine_submit(tx)); - if (ret) { - dmaengine_unmap_put(unmap); + if (ret) goto err_free_resource; - } dmaengine_unmap_put(unmap); |