diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2024-11-17 13:03:32 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-02-08 09:57:26 +0100 |
| commit | 2bf01c4600a1772efc05ba5d32dcbbc6c2997257 (patch) | |
| tree | b25f333172dbd5c95c9af6348d6186aec93b0cf9 | |
| parent | d3269ace1058c2e0599975650dbaf42adc011d7b (diff) | |
| download | linux-2bf01c4600a1772efc05ba5d32dcbbc6c2997257.tar.gz linux-2bf01c4600a1772efc05ba5d32dcbbc6c2997257.tar.bz2 linux-2bf01c4600a1772efc05ba5d32dcbbc6c2997257.zip | |
pinctrl: samsung: Fix irq handling if an error occurs in exynos_irq_demux_eint16_31()
[ Upstream commit f686a2b52e9d78cf401f1b7f446bf0c3a81ebcc0 ]
chained_irq_enter(() should be paired with a corresponding
chained_irq_exit().
Here, if clk_enable() fails, a early return occurs and chained_irq_exit()
is not called.
Add a new label and a goto for fix it.
Fixes: f9c744747973 ("pinctrl: samsung: support a bus clock")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: André Draszik <andre.draszik@linaro.org>
Link: https://lore.kernel.org/r/f148d823acfb3326a115bd49a0eed60f2345f909.1731844995.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/pinctrl/samsung/pinctrl-exynos.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c index b79c211c0374..ac6dc22b37c9 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -636,7 +636,7 @@ static void exynos_irq_demux_eint16_31(struct irq_desc *desc) if (clk_enable(b->drvdata->pclk)) { dev_err(b->gpio_chip.parent, "unable to enable clock for pending IRQs\n"); - return; + goto out; } } @@ -652,6 +652,7 @@ static void exynos_irq_demux_eint16_31(struct irq_desc *desc) if (eintd->nr_banks) clk_disable(eintd->banks[0]->drvdata->pclk); +out: chained_irq_exit(chip, desc); } |