diff options
| author | Colin Ian King <colin.i.king@gmail.com> | 2024-10-02 17:53:29 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-12-09 10:31:53 +0100 |
| commit | 3164cc7cf77acd7df6a56ac0246544b64d516635 (patch) | |
| tree | d52e477b1b092d030b80d84fc9ea85b4e4c4fb42 | |
| parent | f8549e3f03c1824b367eb8c9c43ddc2be99939c8 (diff) | |
| download | linux-3164cc7cf77acd7df6a56ac0246544b64d516635.tar.gz linux-3164cc7cf77acd7df6a56ac0246544b64d516635.tar.bz2 linux-3164cc7cf77acd7df6a56ac0246544b64d516635.zip | |
media: i2c: ds90ub960: Fix missing return check on ub960_rxport_read call
[ Upstream commit 24ad2d1f773a11f69eecec3ec37ea3d76f2e9e7d ]
The function ub960_rxport_read is being called and afterwards ret is
being checked for any failures, however ret is not being assigned to
the return of the function call. Fix this by assigning ret to the
return of the call which appears to be missing.
Fixes: afe267f2d368 ("media: i2c: add DS90UB960 driver")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/media/i2c/ds90ub960.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c index 8ba5750f5a23..7f30e8923633 100644 --- a/drivers/media/i2c/ds90ub960.c +++ b/drivers/media/i2c/ds90ub960.c @@ -1286,7 +1286,7 @@ static int ub960_rxport_get_strobe_pos(struct ub960_data *priv, clk_delay += v & UB960_IR_RX_ANA_STROBE_SET_CLK_DELAY_MASK; - ub960_rxport_read(priv, nport, UB960_RR_SFILTER_STS_1, &v); + ret = ub960_rxport_read(priv, nport, UB960_RR_SFILTER_STS_1, &v); if (ret) return ret; |