diff options
| author | Ovidiu Panait <ovidiu.panait@windriver.com> | 2023-12-24 10:21:34 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-01-25 15:35:18 -0800 |
| commit | 3c3eb0f8bb26d0a8c19d778cf4e54e373bb57cd2 (patch) | |
| tree | 9402dd58189903e5b0ef87efee7553e4fc49f25b | |
| parent | db6efd4da2eedbb1b243bb42c802014b1e126a67 (diff) | |
| download | linux-3c3eb0f8bb26d0a8c19d778cf4e54e373bb57cd2.tar.gz linux-3c3eb0f8bb26d0a8c19d778cf4e54e373bb57cd2.tar.bz2 linux-3c3eb0f8bb26d0a8c19d778cf4e54e373bb57cd2.zip | |
crypto: sahara - improve error handling in sahara_sha_process()
[ Upstream commit 5deff027fca49a1eb3b20359333cf2ae562a2343 ]
sahara_sha_hw_data_descriptor_create() returns negative error codes on
failure, so make sure the errors are correctly handled / propagated.
Fixes: 5a2bb93f5992 ("crypto: sahara - add support for SHA1/256")
Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/crypto/sahara.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c index 86ff5add2e15..117aa4296c2a 100644 --- a/drivers/crypto/sahara.c +++ b/drivers/crypto/sahara.c @@ -987,7 +987,10 @@ static int sahara_sha_process(struct ahash_request *req) return ret; if (rctx->first) { - sahara_sha_hw_data_descriptor_create(dev, rctx, req, 0); + ret = sahara_sha_hw_data_descriptor_create(dev, rctx, req, 0); + if (ret) + return ret; + dev->hw_desc[0]->next = 0; rctx->first = 0; } else { @@ -995,7 +998,10 @@ static int sahara_sha_process(struct ahash_request *req) sahara_sha_hw_context_descriptor_create(dev, rctx, req, 0); dev->hw_desc[0]->next = dev->hw_phys_desc[1]; - sahara_sha_hw_data_descriptor_create(dev, rctx, req, 1); + ret = sahara_sha_hw_data_descriptor_create(dev, rctx, req, 1); + if (ret) + return ret; + dev->hw_desc[1]->next = 0; } |