diff options
| author | Christophe Leroy <christophe.leroy@csgroup.eu> | 2024-12-05 20:46:16 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-02-08 10:02:06 +0100 |
| commit | 4fb3fa81ff0f6e05e395ba95220cdec72ae9422d (patch) | |
| tree | dd256364b11da752bb6ff4e76868e0ccbf2c09b5 | |
| parent | 78cf26ebe662838864fe83f6f50c129930770f8f (diff) | |
| download | linux-4fb3fa81ff0f6e05e395ba95220cdec72ae9422d.tar.gz linux-4fb3fa81ff0f6e05e395ba95220cdec72ae9422d.tar.bz2 linux-4fb3fa81ff0f6e05e395ba95220cdec72ae9422d.zip | |
module: Don't fail module loading when setting ro_after_init section RO failed
[ Upstream commit 110b1e070f1d50f5217bd2c758db094998bb7b77 ]
Once module init has succeded it is too late to cancel loading.
If setting ro_after_init data section to read-only fails, all we
can do is to inform the user through a warning.
Reported-by: Thomas Gleixner <tglx@linutronix.de>
Closes: https://lore.kernel.org/all/20230915082126.4187913-1-ruanjinjie@huawei.com/
Fixes: d1909c022173 ("module: Don't ignore errors from set_memory_XX()")
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Link: https://lore.kernel.org/r/d6c81f38da76092de8aacc8c93c4c65cb0fe48b8.1733427536.git.christophe.leroy@csgroup.eu
Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | kernel/module/main.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/kernel/module/main.c b/kernel/module/main.c index 5399c182b3cb..c740d208b52a 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -2950,7 +2950,10 @@ static noinline int do_init_module(struct module *mod) #endif ret = module_enable_rodata_ro(mod, true); if (ret) - goto fail_mutex_unlock; + pr_warn("%s: module_enable_rodata_ro_after_init() returned %d, " + "ro_after_init data might still be writable\n", + mod->name, ret); + mod_tree_remove_init(mod); module_arch_freeing_init(mod); for_class_mod_mem_type(type, init) { @@ -2989,8 +2992,6 @@ static noinline int do_init_module(struct module *mod) return 0; -fail_mutex_unlock: - mutex_unlock(&module_mutex); fail_free_freeinit: kfree(freeinit); fail: |