diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2024-10-15 10:55:55 -0700 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-10-15 10:55:55 -0700 |
| commit | 6d858708d465669ba7de17e9c5691eb4019166e8 (patch) | |
| tree | 46229040a9e71afc650d21d7f281a59e6666b37e | |
| parent | b1a39cd855bae5d9f43a04746f69564170892482 (diff) | |
| parent | 45fe45fada261e1e83fce2a07fa22835aec1cf0a (diff) | |
| download | linux-6d858708d465669ba7de17e9c5691eb4019166e8.tar.gz linux-6d858708d465669ba7de17e9c5691eb4019166e8.tar.bz2 linux-6d858708d465669ba7de17e9c5691eb4019166e8.zip | |
Merge branch 'net-ethernet-freescale-use-pa-to-format-resource_size_t'
Simon Horman says:
====================
net: ethernet: freescale: Use %pa to format resource_size_t
This short series addersses the formatting of variables of
type resource_size_t in freescale drivers.
The correct format string for resource_size_t is %pa which
acts on the address of the variable to be formatted [1].
[1] https://elixir.bootlin.com/linux/v6.11.3/source/Documentation/core-api/printk-formats.rst#L229
These problems were introduced by
commit 9d9326d3bc0e ("phy: Change mii_bus id field to a string")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Closes: https://lore.kernel.org/netdev/711d7f6d-b785-7560-f4dc-c6aad2cce99@linux-m68k.org/
Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
====================
Link: https://patch.msgid.link/20241014-net-pa-fmt-v1-0-dcc9afb8858b@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/ethernet/freescale/fec_mpc52xx_phy.c | 2 | ||||
| -rw-r--r-- | drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/freescale/fec_mpc52xx_phy.c b/drivers/net/ethernet/freescale/fec_mpc52xx_phy.c index 2c37004bb0fe..3d073f0fae63 100644 --- a/drivers/net/ethernet/freescale/fec_mpc52xx_phy.c +++ b/drivers/net/ethernet/freescale/fec_mpc52xx_phy.c @@ -94,7 +94,7 @@ static int mpc52xx_fec_mdio_probe(struct platform_device *of) goto out_free; } - snprintf(bus->id, MII_BUS_ID_SIZE, "%x", res.start); + snprintf(bus->id, MII_BUS_ID_SIZE, "%pa", &res.start); bus->priv = priv; bus->parent = dev; diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c index e6b2d7452fe7..66038e2a4ae3 100644 --- a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c +++ b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c @@ -123,7 +123,7 @@ static int fs_mii_bitbang_init(struct mii_bus *bus, struct device_node *np) * we get is an int, and the odds of multiple bitbang mdio buses * is low enough that it's not worth going too crazy. */ - snprintf(bus->id, MII_BUS_ID_SIZE, "%x", res.start); + snprintf(bus->id, MII_BUS_ID_SIZE, "%pa", &res.start); data = of_get_property(np, "fsl,mdio-pin", &len); if (!data || len != 4) |