diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-09-13 17:34:54 +0300 |
|---|---|---|
| committer | Thierry Reding <treding@nvidia.com> | 2024-10-24 18:50:04 +0200 |
| commit | a85df8c7b5ee2d3d4823befada42c5c41aff4cb0 (patch) | |
| tree | 9d2c9ebddfc8fca26e80c2018e02c76f2e505096 | |
| parent | 5c23878252515b8d2b86839bd4cb7dea7088aacd (diff) | |
| download | linux-a85df8c7b5ee2d3d4823befada42c5c41aff4cb0.tar.gz linux-a85df8c7b5ee2d3d4823befada42c5c41aff4cb0.tar.bz2 linux-a85df8c7b5ee2d3d4823befada42c5c41aff4cb0.zip | |
drm/tegra: Fix NULL vs IS_ERR() check in probe()
The iommu_paging_domain_alloc() function doesn't return NULL pointers,
it returns error pointers. Update the check to match.
Fixes: 45c690aea8ee ("drm/tegra: Use iommu_paging_domain_alloc()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/ba31cf3a-af3d-4ff1-87a8-f05aaf8c780b@stanley.mountain
| -rw-r--r-- | drivers/gpu/drm/tegra/drm.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index c9eb329665ec..34d22ba210b0 100644 --- a/drivers/gpu/drm/tegra/drm.c +++ b/drivers/gpu/drm/tegra/drm.c @@ -1153,8 +1153,8 @@ static int host1x_drm_probe(struct host1x_device *dev) if (host1x_drm_wants_iommu(dev) && device_iommu_mapped(dma_dev)) { tegra->domain = iommu_paging_domain_alloc(dma_dev); - if (!tegra->domain) { - err = -ENOMEM; + if (IS_ERR(tegra->domain)) { + err = PTR_ERR(tegra->domain); goto free; } |