summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMika Westerberg <mika.westerberg@linux.intel.com>2025-03-05 14:56:20 +0200
committerMika Westerberg <mika.westerberg@linux.intel.com>2025-03-17 12:24:56 +0200
commitad79c278e478ca8c1a3bf8e7a0afba8f862a48a1 (patch)
treebdcc781dc4d9b94b3d641520c8b9d34c2d912541
parent75749d2c1d8cef439f8b69fa1f4f36d0fc3193e6 (diff)
downloadlinux-ad79c278e478ca8c1a3bf8e7a0afba8f862a48a1.tar.gz
linux-ad79c278e478ca8c1a3bf8e7a0afba8f862a48a1.tar.bz2
linux-ad79c278e478ca8c1a3bf8e7a0afba8f862a48a1.zip
thunderbolt: Do not add non-active NVM if NVM upgrade is disabled for retimer
This is only used to write a new NVM in order to upgrade the retimer firmware. It does not make sense to expose it if upgrade is disabled. This also makes it consistent with the router NVM upgrade. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
-rw-r--r--drivers/thunderbolt/retimer.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/thunderbolt/retimer.c b/drivers/thunderbolt/retimer.c
index 1f25529fe05d..361fece3d818 100644
--- a/drivers/thunderbolt/retimer.c
+++ b/drivers/thunderbolt/retimer.c
@@ -93,9 +93,11 @@ static int tb_retimer_nvm_add(struct tb_retimer *rt)
if (ret)
goto err_nvm;
- ret = tb_nvm_add_non_active(nvm, nvm_write);
- if (ret)
- goto err_nvm;
+ if (!rt->no_nvm_upgrade) {
+ ret = tb_nvm_add_non_active(nvm, nvm_write);
+ if (ret)
+ goto err_nvm;
+ }
rt->nvm = nvm;
dev_dbg(&rt->dev, "NVM version %x.%x\n", nvm->major, nvm->minor);