diff options
| author | Charles Han <hanchunchao@inspur.com> | 2024-11-14 17:19:47 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-02-21 14:01:15 +0100 |
| commit | b99dbdee8a89c44d03ae9830ab19f31e124a3f32 (patch) | |
| tree | 0c417278c9e2835a247bef7dae8c12ba9847cd76 | |
| parent | 59b55b65a96df62b19b762587b3bd1cdbd55d55a (diff) | |
| download | linux-b99dbdee8a89c44d03ae9830ab19f31e124a3f32.tar.gz linux-b99dbdee8a89c44d03ae9830ab19f31e124a3f32.tar.bz2 linux-b99dbdee8a89c44d03ae9830ab19f31e124a3f32.zip | |
HID: winwing: Add NULL check in winwing_init_led()
[ Upstream commit 45ab5166a82d038c898985b0ad43ead69c1f9573 ]
devm_kasprintf() can return a NULL pointer on failure,but this
returned value in winwing_init_led() is not checked.
Add NULL check in winwing_init_led(), to handle kernel NULL
pointer dereference error.
Fixes: 266c990debad ("HID: Add WinWing Orion2 throttle support")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/hid/hid-winwing.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/hid/hid-winwing.c b/drivers/hid/hid-winwing.c index 831b760c66ea..d4afbbd27807 100644 --- a/drivers/hid/hid-winwing.c +++ b/drivers/hid/hid-winwing.c @@ -106,6 +106,8 @@ static int winwing_init_led(struct hid_device *hdev, "%s::%s", dev_name(&input->dev), info->led_name); + if (!led->cdev.name) + return -ENOMEM; ret = devm_led_classdev_register(&hdev->dev, &led->cdev); if (ret) |