summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYurii Monakov <monakov.y@gmail.com>2019-12-17 14:38:36 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-02-11 04:34:00 -0800
commitc659ea7b9d0750eb16fac6ab449055984fd6a24c (patch)
tree0336100f443de026fd0e6fd86e89b084e7f801e6
parent2554cdfa1d0369083bca97df2a5b121a276e11ad (diff)
downloadlinux-c659ea7b9d0750eb16fac6ab449055984fd6a24c.tar.gz
linux-c659ea7b9d0750eb16fac6ab449055984fd6a24c.tar.bz2
linux-c659ea7b9d0750eb16fac6ab449055984fd6a24c.zip
PCI: keystone: Fix link training retries initiation
[ Upstream commit 6df19872d881641e6394f93ef2938cffcbdae5bb ] ks_pcie_stop_link() function does not clear LTSSM_EN_VAL bit so link training was not triggered more than once after startup. In configurations where link can be unstable during early boot, for example, under low temperature, it will never be established. Fixes: 0c4ffcfe1fbc ("PCI: keystone: Add TI Keystone PCIe driver") Signed-off-by: Yurii Monakov <monakov.y@gmail.com> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Acked-by: Andrew Murray <andrew.murray@arm.com> Cc: stable@vger.kernel.org Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/pci/controller/dwc/pci-keystone-dw.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pci/controller/dwc/pci-keystone-dw.c b/drivers/pci/controller/dwc/pci-keystone-dw.c
index 0682213328e9..15c612e853af 100644
--- a/drivers/pci/controller/dwc/pci-keystone-dw.c
+++ b/drivers/pci/controller/dwc/pci-keystone-dw.c
@@ -425,7 +425,7 @@ void ks_dw_pcie_initiate_link_train(struct keystone_pcie *ks_pcie)
/* Disable Link training */
val = ks_dw_app_readl(ks_pcie, CMD_STATUS);
val &= ~LTSSM_EN_VAL;
- ks_dw_app_writel(ks_pcie, CMD_STATUS, LTSSM_EN_VAL | val);
+ ks_dw_app_writel(ks_pcie, CMD_STATUS, val);
/* Initiate Link Training */
val = ks_dw_app_readl(ks_pcie, CMD_STATUS);