diff options
| author | Yang Li <yang.lee@linux.alibaba.com> | 2023-07-27 09:43:15 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-09-13 09:42:24 +0200 |
| commit | c70b9758eebe2de7fd7ffdc6083b3149fc1f195c (patch) | |
| tree | 9e37b930ec1e309756c8013ff4d37105df972f96 | |
| parent | acf4ec3b4244589b8a09e65c6203293e627d3625 (diff) | |
| download | linux-c70b9758eebe2de7fd7ffdc6083b3149fc1f195c.tar.gz linux-c70b9758eebe2de7fd7ffdc6083b3149fc1f195c.tar.bz2 linux-c70b9758eebe2de7fd7ffdc6083b3149fc1f195c.zip | |
platform/x86/amd/pmf: Fix unsigned comparison with less than zero
[ Upstream commit 785c00993dc4c4bb2f7b0f3a3f29c03a6f7aab2e ]
The return value from the call to amd_pmf_get_pprof_modes() is int.
However, the return value is being assigned to an unsigned char
variable 'mode', so making 'mode' an int.
silence the warning:
./drivers/platform/x86/amd/pmf/sps.c:183:5-9: WARNING: Unsigned expression compared with zero: mode < 0
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5995
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/20230727014315.51375-1-yang.lee@linux.alibaba.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/platform/x86/amd/pmf/sps.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/platform/x86/amd/pmf/sps.c b/drivers/platform/x86/amd/pmf/sps.c index fd448844de20..b2cf62937227 100644 --- a/drivers/platform/x86/amd/pmf/sps.c +++ b/drivers/platform/x86/amd/pmf/sps.c @@ -121,7 +121,8 @@ int amd_pmf_get_pprof_modes(struct amd_pmf_dev *pmf) int amd_pmf_power_slider_update_event(struct amd_pmf_dev *dev) { - u8 mode, flag = 0; + u8 flag = 0; + int mode; int src; mode = amd_pmf_get_pprof_modes(dev); |