diff options
| author | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2023-04-11 22:14:27 +0300 |
|---|---|---|
| committer | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2023-04-20 21:45:47 +0300 |
| commit | da57e3d6ed433bbfc52730aec111afb6856f9441 (patch) | |
| tree | 883ae88a5c26e5e513ef59689fd0a94d40df5ce2 | |
| parent | 2590ef92cdff017ac98012593db54c4d5b96388d (diff) | |
| download | linux-da57e3d6ed433bbfc52730aec111afb6856f9441.tar.gz linux-da57e3d6ed433bbfc52730aec111afb6856f9441.tar.bz2 linux-da57e3d6ed433bbfc52730aec111afb6856f9441.zip | |
drm/i915/psr: Add a FIXME for the PSR vs. AUX usage conflict
We need to disable PSR when we are doing AUX by hand, otherwise
it's possible that the PSR hardware could be using the AUX CH
while we try to do our manual stuff. Add a FIXME for now.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230411191429.29895-7-ville.syrjala@linux.intel.com
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
| -rw-r--r-- | drivers/gpu/drm/i915/display/intel_dp_aux.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c index 705915d50565..abf77ba76972 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c @@ -268,6 +268,11 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp, intel_pps_check_power_unlocked(intel_dp); + /* + * FIXME PSR should be disabled here to prevent + * it using the same AUX CH simultaneously + */ + /* Try to wait for any previous AUX channel activity */ for (try = 0; try < 3; try++) { status = intel_de_read_notrace(i915, ch_ctl); |