diff options
author | Lucas De Marchi <lucas.demarchi@intel.com> | 2023-02-24 16:15:38 -0800 |
---|---|---|
committer | Rodrigo Vivi <rodrigo.vivi@intel.com> | 2023-12-19 18:29:20 -0500 |
commit | ea9f879d037ff4d7851f35ba91dc774dd9033308 (patch) | |
tree | 00617cb462720703cf2eeef6174ef6c47d2b42be | |
parent | ba11f1b7ea5b59fdf58e5dec7b73fa914de65f8d (diff) | |
download | linux-ea9f879d037ff4d7851f35ba91dc774dd9033308.tar.gz linux-ea9f879d037ff4d7851f35ba91dc774dd9033308.tar.bz2 linux-ea9f879d037ff4d7851f35ba91dc774dd9033308.zip |
drm/xe: Sort includes
Sort includes and split them in blocks:
1) .h corresponding to the .c. Example: xe_bb.c should have a "#include
"xe_bb.h" first.
2) #include <linux/...>
3) #include <drm/...>
4) local includes
5) i915 includes
This is accomplished by running
`clang-format --style=file -i --sort-includes drivers/gpu/drm/xe/*.[ch]`
and ignoring all the changes after the includes. There are also some
manual tweaks to split the blocks.
v2: Also sort includes in headers
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
66 files changed, 172 insertions, 125 deletions
diff --git a/drivers/gpu/drm/xe/xe_bb.c b/drivers/gpu/drm/xe/xe_bb.c index 8b9209571fd0..d10448d1b4d7 100644 --- a/drivers/gpu/drm/xe/xe_bb.c +++ b/drivers/gpu/drm/xe/xe_bb.c @@ -4,10 +4,11 @@ */ #include "xe_bb.h" -#include "xe_sa.h" + #include "xe_device.h" #include "xe_engine_types.h" #include "xe_hw_fence.h" +#include "xe_sa.h" #include "xe_sched_job.h" #include "xe_vm_types.h" diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c index b4fa856b79d1..3e5393e00b43 100644 --- a/drivers/gpu/drm/xe/xe_bo.c +++ b/drivers/gpu/drm/xe/xe_bo.c @@ -3,7 +3,6 @@ * Copyright © 2021 Intel Corporation */ - #include "xe_bo.h" #include <linux/dma-buf.h> diff --git a/drivers/gpu/drm/xe/xe_bo_evict.c b/drivers/gpu/drm/xe/xe_bo_evict.c index 3fb3c8c77efa..bbf89a58cdf5 100644 --- a/drivers/gpu/drm/xe/xe_bo_evict.c +++ b/drivers/gpu/drm/xe/xe_bo_evict.c @@ -3,8 +3,9 @@ * Copyright © 2022 Intel Corporation */ -#include "xe_bo.h" #include "xe_bo_evict.h" + +#include "xe_bo.h" #include "xe_device.h" #include "xe_ggtt.h" #include "xe_gt.h" diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c index b0f8b157ffa3..7827a785b020 100644 --- a/drivers/gpu/drm/xe/xe_debugfs.c +++ b/drivers/gpu/drm/xe/xe_debugfs.c @@ -3,13 +3,14 @@ * Copyright © 2022 Intel Corporation */ +#include "xe_debugfs.h" + #include <linux/string_helpers.h> #include <drm/drm_debugfs.h> #include "xe_bo.h" #include "xe_device.h" -#include "xe_debugfs.h" #include "xe_gt_debugfs.h" #include "xe_step.h" diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c index 8fe0324ccef3..6d7d57d08a99 100644 --- a/drivers/gpu/drm/xe/xe_device.c +++ b/drivers/gpu/drm/xe/xe_device.c @@ -5,12 +5,12 @@ #include "xe_device.h" -#include <drm/drm_gem_ttm_helper.h> #include <drm/drm_aperture.h> +#include <drm/drm_atomic_helper.h> +#include <drm/drm_gem_ttm_helper.h> #include <drm/drm_ioctl.h> -#include <drm/xe_drm.h> #include <drm/drm_managed.h> -#include <drm/drm_atomic_helper.h> +#include <drm/xe_drm.h> #include "xe_bo.h" #include "xe_debugfs.h" @@ -20,8 +20,8 @@ #include "xe_exec.h" #include "xe_gt.h" #include "xe_irq.h" -#include "xe_module.h" #include "xe_mmio.h" +#include "xe_module.h" #include "xe_pcode.h" #include "xe_pm.h" #include "xe_query.h" diff --git a/drivers/gpu/drm/xe/xe_device.h b/drivers/gpu/drm/xe/xe_device.h index 88d55671b068..ed55ef567d18 100644 --- a/drivers/gpu/drm/xe/xe_device.h +++ b/drivers/gpu/drm/xe/xe_device.h @@ -12,8 +12,8 @@ struct xe_file; #include <drm/drm_util.h> #include "xe_device_types.h" -#include "xe_macros.h" #include "xe_force_wake.h" +#include "xe_macros.h" #include "gt/intel_gpu_commands.h" diff --git a/drivers/gpu/drm/xe/xe_dma_buf.c b/drivers/gpu/drm/xe/xe_dma_buf.c index d09ff25bd940..9b252cc782b7 100644 --- a/drivers/gpu/drm/xe/xe_dma_buf.c +++ b/drivers/gpu/drm/xe/xe_dma_buf.c @@ -3,20 +3,19 @@ * Copyright © 2022 Intel Corporation */ +#include "xe_dma_buf.h" + +#include <kunit/test.h> #include <linux/dma-buf.h> +#include <linux/pci-p2pdma.h> #include <drm/drm_device.h> #include <drm/drm_prime.h> - #include <drm/ttm/ttm_tt.h> -#include <kunit/test.h> -#include <linux/pci-p2pdma.h> - #include "tests/xe_test.h" #include "xe_bo.h" #include "xe_device.h" -#include "xe_dma_buf.h" #include "xe_ttm_vram_mgr.h" #include "xe_vm.h" diff --git a/drivers/gpu/drm/xe/xe_engine.c b/drivers/gpu/drm/xe/xe_engine.c index b69dcbef0824..519fbbcabdb9 100644 --- a/drivers/gpu/drm/xe/xe_engine.c +++ b/drivers/gpu/drm/xe/xe_engine.c @@ -5,10 +5,11 @@ #include "xe_engine.h" +#include <linux/nospec.h> + #include <drm/drm_device.h> #include <drm/drm_file.h> #include <drm/xe_drm.h> -#include <linux/nospec.h> #include "xe_device.h" #include "xe_gt.h" diff --git a/drivers/gpu/drm/xe/xe_exec.c b/drivers/gpu/drm/xe/xe_exec.c index 00f298acc436..97fd1a311f2d 100644 --- a/drivers/gpu/drm/xe/xe_exec.c +++ b/drivers/gpu/drm/xe/xe_exec.c @@ -3,6 +3,8 @@ * Copyright © 2022 Intel Corporation */ +#include "xe_exec.h" + #include <drm/drm_device.h> #include <drm/drm_file.h> #include <drm/xe_drm.h> @@ -10,7 +12,6 @@ #include "xe_bo.h" #include "xe_device.h" #include "xe_engine.h" -#include "xe_exec.h" #include "xe_macros.h" #include "xe_sched_job.h" #include "xe_sync.h" diff --git a/drivers/gpu/drm/xe/xe_execlist.c b/drivers/gpu/drm/xe/xe_execlist.c index 47587571123a..8ff1f36f89f7 100644 --- a/drivers/gpu/drm/xe/xe_execlist.c +++ b/drivers/gpu/drm/xe/xe_execlist.c @@ -3,15 +3,15 @@ * Copyright © 2021 Intel Corporation */ -#include <drm/drm_managed.h> - #include "xe_execlist.h" +#include <drm/drm_managed.h> + #include "xe_bo.h" #include "xe_device.h" #include "xe_engine.h" -#include "xe_hw_fence.h" #include "xe_gt.h" +#include "xe_hw_fence.h" #include "xe_lrc.h" #include "xe_macros.h" #include "xe_mmio.h" @@ -19,11 +19,11 @@ #include "xe_ring_ops_types.h" #include "xe_sched_job.h" -#include "i915_reg.h" +#include "gt/intel_engine_regs.h" #include "gt/intel_gpu_commands.h" #include "gt/intel_gt_regs.h" #include "gt/intel_lrc_reg.h" -#include "gt/intel_engine_regs.h" +#include "i915_reg.h" #define XE_EXECLIST_HANG_LIMIT 1 diff --git a/drivers/gpu/drm/xe/xe_force_wake.c b/drivers/gpu/drm/xe/xe_force_wake.c index 21d04a02847b..1ead587cd5c9 100644 --- a/drivers/gpu/drm/xe/xe_force_wake.c +++ b/drivers/gpu/drm/xe/xe_force_wake.c @@ -3,13 +3,14 @@ * Copyright © 2022 Intel Corporation */ +#include "xe_force_wake.h" + #include <drm/drm_util.h> -#include "xe_force_wake.h" #include "xe_gt.h" #include "xe_mmio.h" -#include "gt/intel_gt_regs.h" +#include "gt/intel_gt_regs.h" #define XE_FORCE_WAKE_ACK_TIMEOUT_MS 50 diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c index 907a603572b2..3730bbeb26b2 100644 --- a/drivers/gpu/drm/xe/xe_ggtt.c +++ b/drivers/gpu/drm/xe/xe_ggtt.c @@ -6,20 +6,20 @@ #include "xe_ggtt.h" #include <linux/sizes.h> -#include <drm/i915_drm.h> #include <drm/drm_managed.h> +#include <drm/i915_drm.h> -#include "xe_device.h" #include "xe_bo.h" +#include "xe_device.h" #include "xe_gt.h" #include "xe_gt_tlb_invalidation.h" #include "xe_map.h" #include "xe_mmio.h" #include "xe_wopcm.h" -#include "i915_reg.h" #include "gt/intel_gt_regs.h" +#include "i915_reg.h" /* FIXME: Common file, preferably auto-gen */ #define MTL_GGTT_PTE_PAT0 BIT_ULL(52) diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c index 5a3c8fd5936a..74e9445befe4 100644 --- a/drivers/gpu/drm/xe/xe_gt.c +++ b/drivers/gpu/drm/xe/xe_gt.c @@ -3,6 +3,8 @@ * Copyright © 2022 Intel Corporation */ +#include "xe_gt.h" + #include <linux/minmax.h> #include <drm/drm_managed.h> @@ -14,7 +16,6 @@ #include "xe_execlist.h" #include "xe_force_wake.h" #include "xe_ggtt.h" -#include "xe_gt.h" #include "xe_gt_clock.h" #include "xe_gt_mcr.h" #include "xe_gt_pagefault.h" diff --git a/drivers/gpu/drm/xe/xe_gt_clock.c b/drivers/gpu/drm/xe/xe_gt_clock.c index 575433e9718a..2d9f2aa42bad 100644 --- a/drivers/gpu/drm/xe/xe_gt_clock.c +++ b/drivers/gpu/drm/xe/xe_gt_clock.c @@ -3,15 +3,16 @@ * Copyright © 2022 Intel Corporation */ -#include "i915_reg.h" -#include "gt/intel_gt_regs.h" +#include "xe_gt_clock.h" #include "xe_device.h" #include "xe_gt.h" -#include "xe_gt_clock.h" #include "xe_macros.h" #include "xe_mmio.h" +#include "gt/intel_gt_regs.h" +#include "i915_reg.h" + static u32 read_reference_ts_freq(struct xe_gt *gt) { u32 ts_override = xe_mmio_read32(gt, GEN9_TIMESTAMP_OVERRIDE.reg); diff --git a/drivers/gpu/drm/xe/xe_gt_debugfs.c b/drivers/gpu/drm/xe/xe_gt_debugfs.c index c320e58810ce..78942e12e76c 100644 --- a/drivers/gpu/drm/xe/xe_gt_debugfs.c +++ b/drivers/gpu/drm/xe/xe_gt_debugfs.c @@ -3,6 +3,8 @@ * Copyright © 2022 Intel Corporation */ +#include "xe_gt_debugfs.h" + #include <drm/drm_debugfs.h> #include <drm/drm_managed.h> @@ -10,7 +12,6 @@ #include "xe_force_wake.h" #include "xe_ggtt.h" #include "xe_gt.h" -#include "xe_gt_debugfs.h" #include "xe_gt_mcr.h" #include "xe_gt_topology.h" #include "xe_hw_engine.h" diff --git a/drivers/gpu/drm/xe/xe_gt_mcr.c b/drivers/gpu/drm/xe/xe_gt_mcr.c index 7617f0340879..8fa59988d08e 100644 --- a/drivers/gpu/drm/xe/xe_gt_mcr.c +++ b/drivers/gpu/drm/xe/xe_gt_mcr.c @@ -3,8 +3,9 @@ * Copyright © 2022 Intel Corporation */ -#include "xe_gt.h" #include "xe_gt_mcr.h" + +#include "xe_gt.h" #include "xe_gt_topology.h" #include "xe_gt_types.h" #include "xe_mmio.h" diff --git a/drivers/gpu/drm/xe/xe_gt_pagefault.c b/drivers/gpu/drm/xe/xe_gt_pagefault.c index ce79eb48feb8..0e7047b89a83 100644 --- a/drivers/gpu/drm/xe/xe_gt_pagefault.c +++ b/drivers/gpu/drm/xe/xe_gt_pagefault.c @@ -3,6 +3,8 @@ * Copyright © 2022 Intel Corporation */ +#include "xe_gt_pagefault.h" + #include <linux/circ_buf.h> #include <drm/drm_managed.h> @@ -10,7 +12,6 @@ #include "xe_bo.h" #include "xe_gt.h" -#include "xe_gt_pagefault.h" #include "xe_gt_tlb_invalidation.h" #include "xe_guc.h" #include "xe_guc_ct.h" diff --git a/drivers/gpu/drm/xe/xe_gt_sysfs.c b/drivers/gpu/drm/xe/xe_gt_sysfs.c index 2d966d935b8e..c01cc689058c 100644 --- a/drivers/gpu/drm/xe/xe_gt_sysfs.c +++ b/drivers/gpu/drm/xe/xe_gt_sysfs.c @@ -3,11 +3,14 @@ * Copyright © 2022 Intel Corporation */ +#include "xe_gt_sysfs.h" + #include <linux/kobject.h> #include <linux/sysfs.h> + #include <drm/drm_managed.h> + #include "xe_gt.h" -#include "xe_gt_sysfs.h" static void xe_gt_sysfs_kobj_release(struct kobject *kobj) { diff --git a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c index 2521c8a65690..f279e21300aa 100644 --- a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c +++ b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c @@ -3,8 +3,9 @@ * Copyright © 2023 Intel Corporation */ -#include "xe_gt.h" #include "xe_gt_tlb_invalidation.h" + +#include "xe_gt.h" #include "xe_guc.h" #include "xe_guc_ct.h" #include "xe_trace.h" diff --git a/drivers/gpu/drm/xe/xe_gt_topology.c b/drivers/gpu/drm/xe/xe_gt_topology.c index 3dd7cbbff071..c76aaea1887c 100644 --- a/drivers/gpu/drm/xe/xe_gt_topology.c +++ b/drivers/gpu/drm/xe/xe_gt_topology.c @@ -3,10 +3,11 @@ * Copyright © 2022 Intel Corporation */ +#include "xe_gt_topology.h" + #include <linux/bitmap.h> #include "xe_gt.h" -#include "xe_gt_topology.h" #include "xe_mmio.h" #define XE_MAX_DSS_FUSE_BITS (32 * XE_MAX_DSS_FUSE_REGS) diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c index 32bcc40463e1..db3d8c947603 100644 --- a/drivers/gpu/drm/xe/xe_guc.c +++ b/drivers/gpu/drm/xe/xe_guc.c @@ -3,24 +3,26 @@ * Copyright © 2022 Intel Corporation */ +#include "xe_guc.h" + #include "xe_bo.h" #include "xe_device.h" -#include "xe_guc.h" +#include "xe_force_wake.h" +#include "xe_gt.h" #include "xe_guc_ads.h" #include "xe_guc_ct.h" #include "xe_guc_hwconfig.h" #include "xe_guc_log.h" -#include "xe_guc_reg.h" #include "xe_guc_pc.h" +#include "xe_guc_reg.h" #include "xe_guc_submit.h" -#include "xe_gt.h" +#include "xe_mmio.h" #include "xe_platform_types.h" #include "xe_uc_fw.h" #include "xe_wopcm.h" -#include "xe_mmio.h" -#include "xe_force_wake.h" -#include "i915_reg_defs.h" + #include "gt/intel_gt_regs.h" +#include "i915_reg_defs.h" /* TODO: move to common file */ #define GUC_PVC_MOCS_INDEX_MASK REG_GENMASK(25, 24) diff --git a/drivers/gpu/drm/xe/xe_guc.h b/drivers/gpu/drm/xe/xe_guc.h index 7be33458eef6..74a74051f354 100644 --- a/drivers/gpu/drm/xe/xe_guc.h +++ b/drivers/gpu/drm/xe/xe_guc.h @@ -6,8 +6,8 @@ #ifndef _XE_GUC_H_ #define _XE_GUC_H_ -#include "xe_hw_engine_types.h" #include "xe_guc_types.h" +#include "xe_hw_engine_types.h" #include "xe_macros.h" struct drm_printer; diff --git a/drivers/gpu/drm/xe/xe_guc_ads.c b/drivers/gpu/drm/xe/xe_guc_ads.c index 0c08cecaca40..a4e947f0c557 100644 --- a/drivers/gpu/drm/xe/xe_guc_ads.c +++ b/drivers/gpu/drm/xe/xe_guc_ads.c @@ -3,20 +3,22 @@ * Copyright © 2022 Intel Corporation */ +#include "xe_guc_ads.h" + #include <drm/drm_managed.h> #include "xe_bo.h" #include "xe_gt.h" #include "xe_guc.h" -#include "xe_guc_ads.h" #include "xe_guc_reg.h" #include "xe_hw_engine.h" #include "xe_lrc.h" #include "xe_map.h" #include "xe_mmio.h" #include "xe_platform_types.h" -#include "gt/intel_gt_regs.h" + #include "gt/intel_engine_regs.h" +#include "gt/intel_gt_regs.h" /* Slack of a few additional entries per engine */ #define ADS_REGSET_EXTRA_MAX 8 diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c index 84d4302d4e72..5e00b75d3ca2 100644 --- a/drivers/gpu/drm/xe/xe_guc_ct.c +++ b/drivers/gpu/drm/xe/xe_guc_ct.c @@ -3,6 +3,8 @@ * Copyright © 2022 Intel Corporation */ +#include "xe_guc_ct.h" + #include <linux/bitfield.h> #include <linux/circ_buf.h> #include <linux/delay.h> @@ -12,10 +14,9 @@ #include "xe_bo.h" #include "xe_device.h" #include "xe_gt.h" -#include "xe_guc.h" -#include "xe_guc_ct.h" #include "xe_gt_pagefault.h" #include "xe_gt_tlb_invalidation.h" +#include "xe_guc.h" #include "xe_guc_submit.h" #include "xe_map.h" #include "xe_trace.h" diff --git a/drivers/gpu/drm/xe/xe_guc_ct_types.h b/drivers/gpu/drm/xe/xe_guc_ct_types.h index 17b148bf3735..e0f9063e9b65 100644 --- a/drivers/gpu/drm/xe/xe_guc_ct_types.h +++ b/drivers/gpu/drm/xe/xe_guc_ct_types.h @@ -6,8 +6,8 @@ #ifndef _XE_GUC_CT_TYPES_H_ #define _XE_GUC_CT_TYPES_H_ -#include <linux/iosys-map.h> #include <linux/interrupt.h> +#include <linux/iosys-map.h> #include <linux/spinlock_types.h> #include <linux/wait.h> #include <linux/xarray.h> |