diff options
| author | Sui Jingfeng <sui.jingfeng@linux.dev> | 2024-05-13 23:30:58 +0800 |
|---|---|---|
| committer | Robert Foss <rfoss@kernel.org> | 2024-05-13 18:30:59 +0200 |
| commit | f0a83a2cf9eb99be74b81ff655b01b5a9710525d (patch) | |
| tree | 60d7fd9afaa17a7b5628e00dd2cafcce57434244 | |
| parent | 2262e917b3da5c129086b035677291b2e3e4bab9 (diff) | |
| download | linux-f0a83a2cf9eb99be74b81ff655b01b5a9710525d.tar.gz linux-f0a83a2cf9eb99be74b81ff655b01b5a9710525d.tar.bz2 linux-f0a83a2cf9eb99be74b81ff655b01b5a9710525d.zip | |
drm/bridge: simple-bridge: Remove a redundant check on existence of bridge->encoder
Because the existence of 'bridge->encoder' has already been checked before
the simple_bridge_attach() function get called, and drm_bridge_attach()
will quit with a negative error code returned if it fails for some reasons.
Hence, it is guaranteed that the .encoder member of the drm_bridge instance
is not NULL when the simple_bridge_attach() get called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240513153109.46786-2-sui.jingfeng@linux.dev
| -rw-r--r-- | drivers/gpu/drm/bridge/simple-bridge.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c index 5813a2c4fc5e..2ca89f313cd1 100644 --- a/drivers/gpu/drm/bridge/simple-bridge.c +++ b/drivers/gpu/drm/bridge/simple-bridge.c @@ -116,11 +116,6 @@ static int simple_bridge_attach(struct drm_bridge *bridge, if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) return 0; - if (!bridge->encoder) { - DRM_ERROR("Missing encoder\n"); - return -ENODEV; - } - drm_connector_helper_add(&sbridge->connector, &simple_bridge_con_helper_funcs); ret = drm_connector_init_with_ddc(bridge->dev, &sbridge->connector, |