diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2023-08-08 15:03:58 -0700 |
|---|---|---|
| committer | Dave Hansen <dave.hansen@linux.intel.com> | 2023-08-09 11:58:25 -0700 |
| commit | 2f6df03f80a13ab2e1eb4bf00bbd5e63255756db (patch) | |
| tree | 70c29adb7d0673045b8815e445e15beeef469372 /arch/x86/kernel/apic/bigsmp_32.c | |
| parent | 4114e1686fdc350e4191ca670710b3fa9bd10947 (diff) | |
| download | linux-2f6df03f80a13ab2e1eb4bf00bbd5e63255756db.tar.gz linux-2f6df03f80a13ab2e1eb4bf00bbd5e63255756db.tar.bz2 linux-2f6df03f80a13ab2e1eb4bf00bbd5e63255756db.zip | |
x86/apic: Nuke empty init_apic_ldr() callbacks
apic::init_apic_ldr() is only invoked when the APIC is initialized. So
there is really no point in having:
- Default empty callbacks all over the place
- Two implementations of the actual LDR init function where one is
just unreadable gunk but does exactly the same as the other.
Make the apic::init_apic_ldr() invocation conditional, remove the empty
callbacks and consolidate the two implementation into one.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Michael Kelley <mikelley@microsoft.com>
Tested-by: Sohil Mehta <sohil.mehta@intel.com>
Tested-by: Juergen Gross <jgross@suse.com> # Xen PV (dom0 and unpriv. guest)
Diffstat (limited to 'arch/x86/kernel/apic/bigsmp_32.c')
| -rw-r--r-- | arch/x86/kernel/apic/bigsmp_32.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/arch/x86/kernel/apic/bigsmp_32.c b/arch/x86/kernel/apic/bigsmp_32.c index aba8ce1d3f24..c688af49bf98 100644 --- a/arch/x86/kernel/apic/bigsmp_32.c +++ b/arch/x86/kernel/apic/bigsmp_32.c @@ -28,14 +28,6 @@ static bool bigsmp_check_apicid_used(physid_mask_t *map, int apicid) return false; } -/* - * bigsmp enables physical destination mode - * and doesn't use LDR and DFR - */ -static void bigsmp_init_apic_ldr(void) -{ -} - static void bigsmp_setup_apic_routing(void) { printk(KERN_INFO @@ -108,7 +100,6 @@ static struct apic apic_bigsmp __ro_after_init = { .disable_esr = 1, .check_apicid_used = bigsmp_check_apicid_used, - .init_apic_ldr = bigsmp_init_apic_ldr, .ioapic_phys_id_map = bigsmp_ioapic_phys_id_map, .setup_apic_routing = bigsmp_setup_apic_routing, .cpu_present_to_apicid = default_cpu_present_to_apicid, |