diff options
| author | Uwe Kleine-König <uwe@kleine-koenig.org> | 2021-01-26 22:53:39 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-02-09 12:12:43 +0100 |
| commit | 5f6805327982d1fd45355730e9d1adda616b995b (patch) | |
| tree | d40c5aa5511ed26dd382ab3dcec6159d436397fe /drivers/firmware/google/coreboot_table.c | |
| parent | 1077d4367ab3b97f6db2f66c87289af863652215 (diff) | |
| download | linux-5f6805327982d1fd45355730e9d1adda616b995b.tar.gz linux-5f6805327982d1fd45355730e9d1adda616b995b.tar.bz2 linux-5f6805327982d1fd45355730e9d1adda616b995b.zip | |
firmware: google: make coreboot driver's remove callback return void
All coreboot drivers return 0 unconditionally in their remove callback.
Also the device core ignores the return value of the struct
bus_type::remove(), so make the coreboot remove callback return void
instead of giving driver authors the illusion they could return an error
code here.
All drivers are adapted accordingly.
Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Link: https://lore.kernel.org/r/20210126215339.706021-1-uwe@kleine-koenig.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/firmware/google/coreboot_table.c')
| -rw-r--r-- | drivers/firmware/google/coreboot_table.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/firmware/google/coreboot_table.c b/drivers/firmware/google/coreboot_table.c index 0205987a4fd4..dc83ea118c67 100644 --- a/drivers/firmware/google/coreboot_table.c +++ b/drivers/firmware/google/coreboot_table.c @@ -46,14 +46,13 @@ static int coreboot_bus_probe(struct device *dev) static int coreboot_bus_remove(struct device *dev) { - int ret = 0; struct coreboot_device *device = CB_DEV(dev); struct coreboot_driver *driver = CB_DRV(dev->driver); if (driver->remove) - ret = driver->remove(device); + driver->remove(device); - return ret; + return 0; } static struct bus_type coreboot_bus_type = { |